From: Prakash Sangappa <prakash.sangappa@oracle.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Michal Hocko <mhocko@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrea Arcangeli <aarcange@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Dave Hansen <dave.hansen@intel.com>,
Christoph Hellwig <hch@infradead.org>,
linux-api@vger.kernel.org
Subject: Re: [RFC PATCH] userfaultfd: Add feature to request for a signal delivery
Date: Wed, 28 Jun 2017 11:23:32 -0700 [thread overview]
Message-ID: <3a8e0042-4c49-3ec8-c59f-9036f8e54621@oracle.com> (raw)
In-Reply-To: <20170628131806.GD10091@rapoport-lnx>
On 6/28/17 6:18 AM, Mike Rapoport wrote:
> On Tue, Jun 27, 2017 at 09:01:20AM -0700, Prakash Sangappa wrote:
>> On 6/27/17 8:35 AM, Mike Rapoport wrote:
>>
>>> On Tue, Jun 27, 2017 at 09:06:43AM +0200, Michal Hocko wrote:
>>>> This is an user visible API so let's CC linux-api mailing list.
>>>>
>>>> On Mon 26-06-17 12:46:13, Prakash Sangappa wrote:
>>>>
>>>>> Any access to mapped address over holes in the file, which can occur due
>>>>> to bugs in the application, is considered invalid and expect the process
>>>>> to simply receive a SIGBUS. However, currently when a hole in the file is
>>>>> accessed via the mapped address, kernel/mm attempts to automatically
>>>>> allocate a page at page fault time, resulting in implicitly filling the
>>>>> hole in the file. This may not be the desired behavior for applications
>>>>> like the database that want to explicitly manage page allocations of
>>>>> hugetlbfs files.
>>>> So you register UFFD_FEATURE_SIGBUS on each region tha you are unmapping
>>>> and than just let those offenders die?
>>> If I understand correctly, the database will create the mapping, then it'll
>>> open userfaultfd and register those mappings with the userfault.
>>> Afterwards, when the application accesses a hole userfault will cause
>>> SIGBUS and the application will process it in whatever way it likes, e.g.
>>> just die.
>> Yes.
>>
>>> What I don't understand is why won't you use userfault monitor process that
>>> will take care of the page fault events?
>>> It shouldn't be much overhead running it and it can keep track on all the
>>> userfault file descriptors for you and it will allow more versatile error
>>> handling that SIGBUS.
>>>
>> Co-ordination with the external monitor process by all the database
>> processes
>> to send their userfaultfd is still an overhead.
> You are planning to register in userfaultfd only the holes you punch to
> deallocate pages, am I right?
No, the entire mmap'ed region. The DB processes would mmap(MAP_NORESERVE)
hugetlbfs files, register this mapped address with userfaultfd ones
right after
the mmap() call.
>
> And the co-ordination of the userfault file descriptor with the monitor
> would have been added after calls to fallocate() and userfaultfd_register()?
Well, the database application does not need to deal with a monitor.
>
> I've just been thinking that maybe it would be possible to use
> UFFD_EVENT_REMOVE for this case. We anyway need to implement the generation
> of UFFD_EVENT_REMOVE for the case of hole punching in hugetlbfs for
> non-cooperative userfaultfd. It could be that it will solve your issue as
> well.
>
Will this result in a signal delivery?
In the use case described, the database application does not need any event
for hole punching. Basically, just a signal for any invalid access to
mapped
area over holes in the file.
next prev parent reply other threads:[~2017-06-28 18:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 19:46 [RFC PATCH] userfaultfd: Add feature to request for a signal delivery Prakash Sangappa
2017-06-27 7:06 ` Michal Hocko
2017-06-27 15:35 ` Mike Rapoport
2017-06-27 16:01 ` Prakash Sangappa
2017-06-28 13:18 ` Mike Rapoport
2017-06-28 18:23 ` Prakash Sangappa [this message]
2017-06-29 8:09 ` Michal Hocko
2017-06-29 21:41 ` prakash.sangappa
2017-06-30 9:47 ` Michal Hocko
2017-06-30 13:08 ` Andrea Arcangeli
2017-07-01 0:55 ` prakash sangappa
2017-07-04 16:40 ` Andrea Arcangeli
2017-07-05 22:24 ` prakash.sangappa
2017-07-05 18:41 ` John Stultz
2017-06-29 10:46 ` Mike Rapoport
2017-06-29 21:49 ` prakash.sangappa
2017-06-27 15:47 ` Prakash Sangappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a8e0042-4c49-3ec8-c59f-9036f8e54621@oracle.com \
--to=prakash.sangappa@oracle.com \
--cc=aarcange@redhat.com \
--cc=dave.hansen@intel.com \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).