From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DECAC43613 for ; Mon, 24 Jun 2019 07:33:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA7F9208C3 for ; Mon, 24 Jun 2019 07:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbfFXHd1 (ORCPT ); Mon, 24 Jun 2019 03:33:27 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:19063 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726480AbfFXHd1 (ORCPT ); Mon, 24 Jun 2019 03:33:27 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id DF751AFD1527423AE49E; Mon, 24 Jun 2019 15:33:24 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 24 Jun 2019 15:33:15 +0800 Subject: Re: [PATCH v3 3/8] staging: erofs: move per-CPU buffers implementation to utils.c To: Gao Xiang , Greg Kroah-Hartman CC: , LKML , , , Chao Yu , Miao Xie , Fang Wei , Du Wei , Gao Xiang References: <20190624072258.28362-1-hsiangkao@aol.com> <20190624072258.28362-4-hsiangkao@aol.com> From: Chao Yu Message-ID: <3ab4064f-042e-1838-6e32-5fb7087f4dc1@huawei.com> Date: Mon, 24 Jun 2019 15:33:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190624072258.28362-4-hsiangkao@aol.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/6/24 15:22, Gao Xiang wrote: > From: Gao Xiang > > This patch moves per-CPU buffers to utils.c in order for > the upcoming generic decompression framework to use it. > > Note that I tried to use generic per-CPU buffer or > per-CPU page approaches to clean up further, but obvious > performanace regression (about 2% for sequential read) was > observed. > > Therefore let's leave it as it is instead, just move > to utils.c and I'll try to dig into the root cause later. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,