From: Shuah Khan <shuahkh@osg.samsung.com>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] usb: dwc3 dwc3_exynos_probe() change goto labels to meaningful names
Date: Fri, 17 Mar 2017 08:27:08 -0600 [thread overview]
Message-ID: <3abd0519-3435-4cd4-2c64-6d648aed944b@osg.samsung.com> (raw)
In-Reply-To: <CAFp+6iEQxO7HcW5xJscc9ZWkTy+LoDm7AiNsK8YOd_S3okOGfg@mail.gmail.com>
On 03/17/2017 12:24 AM, Vivek Gautam wrote:
> On Tue, Jan 31, 2017 at 12:55 AM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> Change goto labels to meaningful names from a series of errNs.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>>
>> Rebased to usb-next
>>
>> drivers/usb/dwc3/dwc3-exynos.c | 22 +++++++++++-----------
>> 1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
>> index 1515d45..98f74ff 100644
>> --- a/drivers/usb/dwc3/dwc3-exynos.c
>> +++ b/drivers/usb/dwc3/dwc3-exynos.c
>> @@ -147,53 +147,53 @@ static int dwc3_exynos_probe(struct platform_device *pdev)
>> exynos->vdd33 = devm_regulator_get(dev, "vdd33");
>> if (IS_ERR(exynos->vdd33)) {
>> ret = PTR_ERR(exynos->vdd33);
>> - goto err2;
>> + goto vdd33_err;
>
> While you are changing this in probe, care to change in
> dwc3_exynos_register_phys() as well ?
Yes I can do that.
>
> [snip]
>
> Regards
> Vivek
thanks,
-- Shuah
next prev parent reply other threads:[~2017-03-17 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 19:25 [PATCH] usb: dwc3 dwc3_exynos_probe() change goto labels to meaningful names Shuah Khan
2017-03-16 15:32 ` Shuah Khan
2017-03-17 8:42 ` Felipe Balbi
2017-03-17 6:24 ` Vivek Gautam
2017-03-17 14:27 ` Shuah Khan [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-11 16:45 Shuah Khan
2017-01-11 17:06 ` Javier Martinez Canillas
2017-01-16 10:33 ` Felipe Balbi
2017-01-17 22:09 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3abd0519-3435-4cd4-2c64-6d648aed944b@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).