From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB232C169C4 for ; Fri, 8 Feb 2019 17:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A36F42146E for ; Fri, 8 Feb 2019 17:34:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pehGrqp5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727493AbfBHReQ (ORCPT ); Fri, 8 Feb 2019 12:34:16 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:42933 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbfBHReP (ORCPT ); Fri, 8 Feb 2019 12:34:15 -0500 Received: by mail-pl1-f195.google.com with SMTP id s1so1991109plp.9; Fri, 08 Feb 2019 09:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dTQLnRFK1PvCGsXptcFXYBXClk4v2sDtQSN1ojPkWNw=; b=pehGrqp536Xm5Zdzonsgrev08/8Jt/fe+vadeuRtHPviPnnXw47c0i2dlGtpcgMrEw RpeO0fq0lEVhpiIS/jJMZBmsZ0mzgGJaVKCwxu8pOri2q8y8U23rQfysjSSYTkB6y/7E b0XpvK2gZ3+uoYbGstQ5+xXzAKFJMtyPunNYKwktRGMw1Yv4VCABQuX+JlgF5194h3Pf HhwhtcCNE567XXtGH0yssAlbobU1zWgbcnjHamVJzqzP0E66D3JnxIqZMZNxN6Ik77UF 2+6LOLsvvfOaNdl3ew1A7X9zDe3BEQfcAz5zGTIpt/GA01lY6vjpS/FCIrlyAUqrykyy OZQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dTQLnRFK1PvCGsXptcFXYBXClk4v2sDtQSN1ojPkWNw=; b=sVQUoNzAk5w+SdhGqkoAXuSXZggFTuqqmAskcURN891OA363Vk5MDnGz8+JRs9my/j NnlrLPdlImRM73IdgMY50FoorkLNL8fuwkZfgiYYKtKZ52HuKRhphntlHNUR2w/WhXpn OK9SNBHMiz4D1h7XlUZFaWWtbKxoZZrmeNn8SVDm/jnb8MfabyT3qbjZlYUNFzu+0Mex Ha8dlnVuEdprEsgy/TcnQn96fV3QdzYEHQY/R/tiCWe4FC3Ip3m0MA0DiMciQHLNmRb+ RIIrMOAhMUdlctIJLjGQetTLh1R8+LYAJ4Wc4Bct7Ml+lrUSqVCUwHmnExokU4qUPLJ6 VN9w== X-Gm-Message-State: AHQUAuYh+pIm/0GIJAs19dQgr+Cl9RDp0+T0BZxDzsGCuVy1QcQkftk+ GezSk4guD3eKBoB8GSxAPYqdSook X-Google-Smtp-Source: AHgI3IYO/utJSXM9NicFINq7aLh/hMig5NhiZ5HY1fBUpfKAqynYByzIoo2r91NYGRDha52lYvsmaA== X-Received: by 2002:a17:902:e512:: with SMTP id ck18mr10288085plb.46.1549647254979; Fri, 08 Feb 2019 09:34:14 -0800 (PST) Received: from [192.168.2.145] (ppp91-79-175-49.pppoe.mtu-net.ru. [91.79.175.49]) by smtp.googlemail.com with ESMTPSA id 84sm4422512pfk.134.2019.02.08.09.34.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Feb 2019 09:34:14 -0800 (PST) Subject: Re: [PATCH V16 4/6] i2c: tegra: Add DMA support To: Sowjanya Komatineni , "thierry.reding@gmail.com" , Jonathan Hunter , Mantravadi Karthik , Shardar Mohammed , Timo Alho Cc: "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" References: <1549644314-1481-1-git-send-email-skomatineni@nvidia.com> <1549644314-1481-4-git-send-email-skomatineni@nvidia.com> <4ba38a07-1953-9393-8756-ce555557017a@gmail.com> From: Dmitry Osipenko Message-ID: <3ac41d68-976d-4674-9a31-708195d58eeb@gmail.com> Date: Fri, 8 Feb 2019 20:34:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 08.02.2019 20:29, Sowjanya Komatineni пишет: > >>> >>>> I'm still also suggesting to squash "fix maximum transfer size" into this patch because it is really part of DMA-support enabling. >>> >>> Max transfer length limits apply to PIO also but for DMA its more needed to prevent crash. >>> So had this as patch before DMA as its applicable for both DMA & PIO. >> >> Oh, so the packet_header size also shall be excluded for the PIO as well, really? It looked to me that PIO doesn't have that restriction and we only need to exclude the header size for DMA.. >> >>> We exchanged on this yesterday, so thought the reason you want to squash separate patch and include in this is due to max msg len limit and when moved into hw feature. >> >> If PIO limits are incorrect, then it's absolutely fine to do it in the separate patch. I probably just misunderstood your point. >> >>> Sorry should have verified before sending. Please confirm if I leave max transfer as separate patch or add to this DMA support. Will update along with dma buf size fix. >>> >>> But max transfer limit applied to PIO also and that’s why added it before DMA patch to show its dependency >>> >> >> And then you need to explicitly tell in the commit message that PIO limits are incorrect. > Commit message says Tegra I2C max limit per packets transfer meaning that’s interface transfer limit so applies to both PIO & DMA. > Will add explicitly indicating applicable for both PIO & DMA to be more clear Thank you. >> >> It also probably worth to add a stable-tag to the commit message to request backporting of the limits-fixing patch to the stable kernels: >> >> Cc: stable@vger.kernel.org >> > Sorry I am new to upstream submissions. By adding stable-tag to commit message, do you mean explicitly mentioning this patch applicable to old kernel and adding in patch CC stable@vger.kernel.org? > You just need to add "Cc: stable@vger.kernel.org" to the commit message, like you did for the "Reviewed-by:". Don't add "stable@vger.kernel.org" to the email recipients. See for example [0]. [0] https://lore.kernel.org/patchwork/patch/1001991/