From: "Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: vigneshr@ti.com, tudor.ambarus@microchip.com,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
robh+dt@kernel.org, boris.brezillon@collabora.com,
devicetree@vger.kernel.org, simon.k.r.goldschmidt@gmail.com,
dinguyen@kernel.org, richard@nod.at, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com
Subject: Re: [RESENDPATCH v15 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Fri, 30 Oct 2020 18:08:47 +0800 [thread overview]
Message-ID: <3ac47b27-5399-e0e7-43f3-d4394c26f800@linux.intel.com> (raw)
In-Reply-To: <20201030092329.280466d9@xps13>
Hi Miquel,
Thank you for the review comments...
On 30/10/2020 4:23 pm, Miquel Raynal wrote:
>>>> +
>>>> +static const struct of_device_id ebu_nand_match[] = {
>>>> + { .compatible = "intel,nand-controller", },
>>> No version or soc in the compatible? (not mandatory).
>> Yes, you're right, it should be "intel,lgm-ebunand", but this same driver supports 2 dfferent SOC's , that's the reason kept as generic
>> "intel,nand-controller"
> In this case I guess declaring two compatibles is the way to go.
Ok, Noted.
Best Regards
Vadivel
next prev parent reply other threads:[~2020-10-30 10:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 7:30 [RESENDPATCH v15 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-10-26 7:30 ` [RESENDPATCH v15 1/2] dt-bindings: mtd: Add Nand Flash Controller support for " Ramuthevar,Vadivel MuruganX
2020-10-26 7:30 ` [RESENDPATCH v15 2/2] mtd: rawnand: Add NAND controller support on " Ramuthevar,Vadivel MuruganX
2020-10-28 10:20 ` Miquel Raynal
2020-10-30 3:19 ` Ramuthevar, Vadivel MuruganX
2020-10-30 8:23 ` Miquel Raynal
2020-10-30 10:06 ` Ramuthevar, Vadivel MuruganX
2020-10-30 10:08 ` Ramuthevar, Vadivel MuruganX [this message]
2020-10-30 11:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ac47b27-5399-e0e7-43f3-d4394c26f800@linux.intel.com \
--to=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=boris.brezillon@collabora.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=qi-ming.wu@intel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).