From: Johannes Berg <johannes@sipsolutions.net>
To: "Fedor Pchelkin" <pchelkin@ispras.ru>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Kalle Valo" <kvalo@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH v4] ath9k: verify the expected usb_endpoints are present
Date: Sat, 08 Oct 2022 22:10:16 +0200 [thread overview]
Message-ID: <3acec81e863aa5f184bc5a74916f1470b77552cb.camel@sipsolutions.net> (raw)
In-Reply-To: <20221008120211.24764-1-pchelkin@ispras.ru>
On Sat, 2022-10-08 at 15:02 +0300, Fedor Pchelkin wrote:
>
> + /* Verify the expected endpoints are present */
> + alt = interface->cur_altsetting;
> + if (usb_find_common_endpoints(alt, &bulk_in, &bulk_out, &int_in, &int_out) < 0 ||
> + usb_endpoint_num(bulk_in) != USB_WLAN_RX_PIPE ||
> + usb_endpoint_num(bulk_out) != USB_WLAN_TX_PIPE ||
> + usb_endpoint_num(int_in) != USB_REG_IN_PIPE ||
> + usb_endpoint_num(int_out) != USB_REG_OUT_PIPE) {
> + dev_err(&udev->dev,
> + "ath9k_htc: Device endpoint numbers are not the expected ones\n");
> + return -ENODEV;
>
Indentation somehow got pretty messed up now ..
johannes
next prev parent reply other threads:[~2022-10-08 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 12:04 [PATCH] ath9k: verify the expected usb_endpoints are present Fedor Pchelkin
2022-10-07 17:33 ` Toke Høiland-Jørgensen
2022-10-07 21:24 ` [PATCH v2] " Fedor Pchelkin
2022-10-07 21:29 ` [PATCH v3] " Fedor Pchelkin
2022-10-08 11:09 ` Toke Høiland-Jørgensen
2022-10-08 12:02 ` [PATCH v4] " Fedor Pchelkin
2022-10-08 20:10 ` Johannes Berg [this message]
2022-10-08 21:15 ` [PATCH v5] " Fedor Pchelkin
2022-10-08 22:43 ` Toke Høiland-Jørgensen
2022-10-11 4:44 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3acec81e863aa5f184bc5a74916f1470b77552cb.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=khoroshilov@ispras.ru \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pchelkin@ispras.ru \
--cc=stern@rowland.harvard.edu \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).