From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54EBBC433EF for ; Sat, 21 May 2022 03:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354425AbiEUDI6 (ORCPT ); Fri, 20 May 2022 23:08:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbiEUDIy (ORCPT ); Fri, 20 May 2022 23:08:54 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D185815E61A; Fri, 20 May 2022 20:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=GxNkNtUv6N3Tj2YSbc6Q95yX7yWRN2SSYpLlOny+k3w=; b=LvCw6ToyXw4MKse/VNChJdugHE 2BNemmkXG/9p9KPM3Je0Q4KPOtpd5VEby5fDaWrr8Jf3adgdRGEbQlzoGPPJH7RDKfYDPC5PCKonr Zef6/lHQKmgSBZduaaq/ROYLdNJNDznXMWTy/CaXUNzmVlPvOBkuR23LFBItdOFxE2ZhBrprjddCI WSflXL3NQb0O5CdQWeuEQt6G9O2113/wvJ7/K7L0MJeRU+C1GjqRGKnk/2/S5RDWNCKeVebt1dfWJ 5VkmfGFwmiOmyBIDQA8hfb+f6p0F+vdgElDJG7k0uBE3Hs0BNOV1cArHs8sadeiy+cqNw/eLvuc6Q CBJQMCQw==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsFU1-00EKVz-7v; Sat, 21 May 2022 03:08:49 +0000 Message-ID: <3ae306e0-c6c7-ed12-cacd-62b1c26dba3c@infradead.org> Date: Fri, 20 May 2022 20:08:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: kbuild problem: ERROR: modpost: missing MODULE_LICENSE() in drivers/iio/afe/iio-rescale.o Content-Language: en-US From: Randy Dunlap To: Linux Kbuild mailing list , Masahiro Yamada Cc: "linux-kernel@vger.kernel.org" , linux-iio@vger.kernel.org, Peter Rosin , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development References: <18500f18-9cd5-a81c-4a55-14e999ed4496@infradead.org> In-Reply-To: <18500f18-9cd5-a81c-4a55-14e999ed4496@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/20/22 19:40, Randy Dunlap wrote: > Hi, > > In March I reported that a randconfig build complained: > > ERROR: modpost: missing MODULE_LICENSE() in drivers/iio/afe/iio-rescale.o > > (https://lore.kernel.org/all/16509fb6-e40c-e31b-2c80-264c44b0beb9@infradead.org/) > > I am still seeing this problem so I tried to dig into it a bit. > However, I don't see why get_next_modinfo() and friends don't find the > MODULE_LICENSE() since it is in the iio-rescale.o file. > > (BTW, I see this build error on many different $ARCH [around 15 tested] > and with 2 different versions of GCC.) > > Q1: Is modpost checking both vmlinux and iio-rescale.o for modinfo license > strings? > > It looks like it is, because it appears (?) that modpost is looking at > drivers/iio/test/iio-test-rescale.o (<<<<< a kunit test, which is builtin > in my .config) and at drivers/iio/afe/iio-rescale.o (which is built as a > loadable module). > > Is this confusing modpost? > I renamed drivers/iio/afe/iio-rescale.c to afe-rescale.c and changed its > Makefile entry accordingly and the MODULE_LICENSE error goes away. Oh well. This rename causes drivers/iio/test/iio-test-rescale.c to have build errors, so that's not a solution, just some info... > Is this a modpost error or is kunit messing things up? > > thanks for looking. -- ~Randy