From: Zenghui Yu <yuzenghui@huawei.com>
To: <intel-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Cc: <jani.nikula@linux.intel.com>, <joonas.lahtinen@linux.intel.com>,
<rodrigo.vivi@intel.com>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<ville.syrjala@linux.intel.com>, <tiwai@suse.de>,
<wanghaibin.wang@huawei.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
<linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] drm/i915: Free the returned object of acpi_evaluate_dsm()
Date: Thu, 7 Oct 2021 17:21:18 +0800 [thread overview]
Message-ID: <3ae85963-beab-17d2-05f1-5a490cee1296@huawei.com> (raw)
In-Reply-To: <20210906033541.862-1-yuzenghui@huawei.com>
[+linux-acpi]
ping
On 2021/9/6 11:35, Zenghui Yu wrote:
> As per the comment on top of acpi_evaluate_dsm():
>
> | * Evaluate device's _DSM method with specified GUID, revision id and
> | * function number. Caller needs to free the returned object.
>
> We should free the returned object of acpi_evaluate_dsm() to avoid memory
> leakage. Otherwise the kmemleak splat will be triggered at boot time (if we
> compile kernel with CONFIG_DEBUG_TEST_DRIVER_REMOVE=y).
>
> Fixes: 8e55f99c510f ("drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops")
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/gpu/drm/i915/display/intel_acpi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index 7cfe91fc05f2..68abeaf2d7d4 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -186,13 +186,16 @@ void intel_dsm_get_bios_data_funcs_supported(struct drm_i915_private *i915)
> {
> struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
> acpi_handle dhandle;
> + union acpi_object *obj;
>
> dhandle = ACPI_HANDLE(&pdev->dev);
> if (!dhandle)
> return;
>
> - acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
> - INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
> + obj = acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
> + INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
> + if (obj)
> + ACPI_FREE(obj);
> }
>
> /*
>
next prev parent reply other threads:[~2021-10-07 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 3:35 [PATCH] drm/i915: Free the returned object of acpi_evaluate_dsm() Zenghui Yu
2021-10-07 9:21 ` Zenghui Yu [this message]
2021-10-07 10:10 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ae85963-beab-17d2-05f1-5a490cee1296@huawei.com \
--to=yuzenghui@huawei.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tiwai@suse.de \
--cc=ville.syrjala@linux.intel.com \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).