From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: [PATCH v2 8/9] x86/PVH: adjust function/data placement
Date: Thu, 30 Sep 2021 14:20:42 +0200 [thread overview]
Message-ID: <3b0bb22e-43f4-e459-c5cb-169f996b5669@suse.com> (raw)
In-Reply-To: <9a26d4ff-80a1-e0c1-f528-31a8568d41f7@suse.com>
Two of the variables can live in .init.data, allowing the open-coded
placing in .data to go away. Another "variable" is used to communicate a
size value only to very early assembly code, which hence can be both
const and live in .init.*. Additionally two functions were lacking
__init annotations.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
--- a/arch/x86/platform/pvh/enlighten.c
+++ b/arch/x86/platform/pvh/enlighten.c
@@ -16,15 +16,15 @@
/*
* PVH variables.
*
- * pvh_bootparams and pvh_start_info need to live in the data segment since
+ * pvh_bootparams and pvh_start_info need to live in a data segment since
* they are used after startup_{32|64}, which clear .bss, are invoked.
*/
-struct boot_params pvh_bootparams __section(".data");
-struct hvm_start_info pvh_start_info __section(".data");
+struct boot_params __initdata pvh_bootparams;
+struct hvm_start_info __initdata pvh_start_info;
-unsigned int pvh_start_info_sz = sizeof(pvh_start_info);
+const unsigned int __initconst pvh_start_info_sz = sizeof(pvh_start_info);
-static u64 pvh_get_root_pointer(void)
+static u64 __init pvh_get_root_pointer(void)
{
return pvh_start_info.rsdp_paddr;
}
@@ -107,7 +107,7 @@ void __init __weak xen_pvh_init(struct b
BUG();
}
-static void hypervisor_specific_init(bool xen_guest)
+static void __init hypervisor_specific_init(bool xen_guest)
{
if (xen_guest)
xen_pvh_init(&pvh_bootparams);
next prev parent reply other threads:[~2021-09-30 12:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 12:12 [PATCH v2 0/9] xen/x86: PVH Dom0 fixes and fallout adjustments Jan Beulich
2021-09-30 12:16 ` [PATCH v2 1/9] xen/x86: prevent PVH type from getting clobbered Jan Beulich
2021-09-30 12:16 ` [PATCH v2 2/9] xen/x86: allow PVH Dom0 without XEN_PV=y Jan Beulich
2021-09-30 12:17 ` [PATCH v2 3/9] xen/x86: make "earlyprintk=xen" work better for PVH Dom0 Jan Beulich
2021-09-30 12:18 ` [PATCH v2 4/9] xen/x86: allow "earlyprintk=xen" to work for PV Dom0 Jan Beulich
2021-09-30 12:18 ` [PATCH v2 5/9] xen/x86: make "earlyprintk=xen" work for HVM/PVH DomU Jan Beulich
2021-09-30 12:19 ` [PATCH v2 6/9] xen/x86: generalize preferred console model from PV to PVH Dom0 Jan Beulich
2021-09-30 12:19 ` [PATCH v2 7/9] xen/x86: hook up xen_banner() also for PVH Jan Beulich
2021-09-30 12:45 ` Juergen Gross
2021-09-30 12:20 ` Jan Beulich [this message]
2021-09-30 12:21 ` [PATCH v2 9/9] xen/x86: adjust data placement Jan Beulich
2021-09-30 12:45 ` Juergen Gross
2021-10-05 6:38 ` [PATCH v2 0/9] xen/x86: PVH Dom0 fixes and fallout adjustments Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b0bb22e-43f4-e459-c5cb-169f996b5669@suse.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).