From: Roger Quadros <rogerq@ti.com>
To: Alexander Kochetkov <al.kochet@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<andrew@lunn.ch>, <nsekhar@ti.com>, <kyle.roeschley@ni.com>
Subject: Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt
Date: Thu, 20 Apr 2017 12:21:10 +0300 [thread overview]
Message-ID: <3b0cca7f-bffe-0717-fbea-7d9ba47a858f@ti.com> (raw)
In-Reply-To: <EA84802B-82E6-4485-A92E-E2751A84D4D0@gmail.com>
Hi,
On 19/04/17 19:53, Alexander Kochetkov wrote:
>
>> 19 апр. 2017 г., в 19:32, Florian Fainelli <f.fainelli@gmail.com> написал(а):
>>
>> http://patchwork.ozlabs.org/patch/743773/
>>
>> Roger can you also test Alexander's patch?
This patch fixes my problem and doesn't have the 1 second delay that my patch had.
So,
Tested-by: Roger Quadros <rogerq@ti.com>
>
> If MAC use phy_start_aneg() instead of phy_start() my patch will not work as
> expected. Roger, if patch don’t work for you please check what MAC bring up PHY using
> phy_start():
Our MAC driver is using phy_start() and I didn't face any issues with your patch.
>
> http://patchwork.ozlabs.org/patch/752308/
>
> Is it correct to start PHY inside MAC probe using phy_start_aneg()? Or phy_start() must be used?
>
> And probably this tags should be added for my patch:
> Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
> Cc: stable <stable@vger.kernel.org> # v4.9+
>
> Because I bisected to commit 529ed1275263 ("net: phy: phy drivers
> should not set SUPPORTED_[Asym_]Pause») that looks pretty good.
>
> Also, there is another issue I found. link_timeout doesn’t work for interrupt driven PHY.
> It is possible to implement timer to handle this case.
> Florian, what do you think? Should this be fixed?
>
> Alexander.
>
cheers,
-roger
next prev parent reply other threads:[~2017-04-20 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 13:46 [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt Alexander Kochetkov
2017-04-19 14:05 ` Alexander Kochetkov
2017-04-19 16:32 ` Florian Fainelli
2017-04-19 16:53 ` Alexander Kochetkov
2017-04-20 9:21 ` Roger Quadros [this message]
2017-04-19 18:11 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b0cca7f-bffe-0717-fbea-7d9ba47a858f@ti.com \
--to=rogerq@ti.com \
--cc=al.kochet@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kyle.roeschley@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).