From: Markus Elfring <Markus.Elfring@web.de>
To: Qinglang Miao <miaoqinglang@huawei.com>,
linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jun Nie <jun.nie@linaro.org>,
Russell King <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] ARM: zx: remove redundant dev_err call in zx296702_pd_probe()
Date: Tue, 28 Jul 2020 17:13:23 +0200 [thread overview]
Message-ID: <3b237263-33eb-d7dc-b6cf-d341f35824de@web.de> (raw)
…
> +++ b/arch/arm/mach-zx/zx296702-pm-domain.c
> @@ -170,7 +170,6 @@ static int zx296702_pd_probe(struct platform_device *pdev)
>
> pcubase = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(pcubase)) {
> - dev_err(&pdev->dev, "ioremap fail.\n");
> return -EIO;
> }
Would you like to delete also the curly brackets besides the error message?
Regards,
Markus
reply other threads:[~2020-07-28 15:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b237263-33eb-d7dc-b6cf-d341f35824de@web.de \
--to=markus.elfring@web.de \
--cc=gregkh@linuxfoundation.org \
--cc=jun.nie@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miaoqinglang@huawei.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).