From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Jon Hunter <jonathanh@nvidia.com>, Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] clocksource/drivers/timer-of: Do not warn on deferred probe
Date: Thu, 22 Aug 2019 08:06:58 +0200 [thread overview]
Message-ID: <3b26d39c-0db4-0bf8-dbec-6d6def0e4307@linaro.org> (raw)
In-Reply-To: <20190821150241.31093-1-jonathanh@nvidia.com>
On 21/08/2019 17:02, Jon Hunter wrote:
> Deferred probe is an expected return value for clk_get() on many
> platforms. The driver deals with it properly, so there's no need
> to output a warning that may potentially confuse users.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
Applied, thanks!
> drivers/clocksource/timer-of.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c
> index 80542289fae7..d8c2bd4391d0 100644
> --- a/drivers/clocksource/timer-of.c
> +++ b/drivers/clocksource/timer-of.c
> @@ -113,8 +113,10 @@ static __init int timer_of_clk_init(struct device_node *np,
> of_clk->clk = of_clk->name ? of_clk_get_by_name(np, of_clk->name) :
> of_clk_get(np, of_clk->index);
> if (IS_ERR(of_clk->clk)) {
> - pr_err("Failed to get clock for %pOF\n", np);
> - return PTR_ERR(of_clk->clk);
> + ret = PTR_ERR(of_clk->clk);
> + if (ret != -EPROBE_DEFER)
> + pr_err("Failed to get clock for %pOF\n", np);
> + goto out;
> }
>
> ret = clk_prepare_enable(of_clk->clk);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2019-08-22 6:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:02 [PATCH 1/2] clocksource/drivers/timer-of: Do not warn on deferred probe Jon Hunter
2019-08-21 15:02 ` [PATCH 2/2] clocksource/drivers: Do not warn on probe defer Jon Hunter
2019-08-22 6:06 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b26d39c-0db4-0bf8-dbec-6d6def0e4307@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).