From: Neil Armstrong <narmstrong@baylibre.com>
To: Adrian Ratiu <adrian.ratiu@collabora.com>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-rockchip@lists.infradead.org
Cc: kernel@collabora.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@collabora.com>
Subject: Re: [PATCH 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap
Date: Mon, 4 Nov 2019 16:46:44 +0100 [thread overview]
Message-ID: <3b3bbf68-a19e-77ea-7e7c-770f75a81a21@baylibre.com> (raw)
In-Reply-To: <87v9rz97bn.fsf@collabora.com>
Hi Adrian,
On 04/11/2019 13:03, Adrian Ratiu wrote:
> On Mon, 04 Nov 2019, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> On 31/10/2019 15:26, Adrian Ratiu wrote:
>>
>> OK for the dw-mipi-dsi changes, but why should the dw_mipi_dsi-stm be changed aswell ?
>> AFAIK these are independent.
>
> I don't understand how they are independent. Isn't the stm driver also using the same dw-mipi-dsi bridge as rockchip and now imx since it was first added in commit
> c1c026dbc183 ("drm/stm: Add STM32 DSI controller driver") ?
>
> I don't have the hardware to test the stm driver on a live boot, but compilation certainly fails if I don't modify it :)
Ignore my comment, this patch is fine, please keep:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
when resending.
Neil
>
>>
>> Neil
next prev parent reply other threads:[~2019-11-04 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 14:26 [PATCH 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver Adrian Ratiu
2019-10-31 14:26 ` [PATCH 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap Adrian Ratiu
2019-11-04 9:15 ` Neil Armstrong
2019-11-04 12:03 ` Adrian Ratiu
2019-11-04 15:46 ` Neil Armstrong [this message]
2019-10-31 14:26 ` [PATCH 2/4] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields Adrian Ratiu
2019-10-31 14:26 ` [PATCH 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver Adrian Ratiu
2019-10-31 14:26 ` [PATCH 4/4] dt-bindings: display: add IMX MIPI DSI host controller doc Adrian Ratiu
2019-10-31 17:07 ` [PATCH 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver Emil Velikov
2019-10-31 19:10 ` Adrian Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3bbf68-a19e-77ea-7e7c-770f75a81a21@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=adrian.ratiu@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).