From: Robin Murphy <robin.murphy@arm.com>
To: Alex Williamson <alex.williamson@redhat.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc: eric.auger@redhat.com, pmorel@linux.vnet.ibm.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, linuxarm@huawei.com,
john.garry@huawei.com, xuwei5@hisilicon.com,
Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH v5 7/7] iommu/dma: Move PCI window region reservation back into dma specific path.
Date: Thu, 22 Mar 2018 17:22:27 +0000 [thread overview]
Message-ID: <3b481ba6-ffdd-fef1-12dc-f5eac8b589d5@arm.com> (raw)
In-Reply-To: <20180322102148.29afce09@w520.home>
On 22/03/18 16:21, Alex Williamson wrote:
> On Thu, 15 Mar 2018 16:35:09 +0000
> Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> wrote:
>
>> This pretty much reverts commit 273df9635385 ("iommu/dma: Make PCI
>> window reservation generic") by moving the PCI window region
>> reservation back into the dma specific path so that these regions
>> doesn't get exposed via the IOMMU API interface. With this change,
>> the vfio interface will report only iommu specific reserved regions
>> to the user space.
>>
>> Cc: Robin Murphy <robin.murphy@arm.com>
>> Cc: Joerg Roedel <joro@8bytes.org>
>> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
>> ---
>
> As currently ordered, we expose the iova list to the user in 5/7 with
> the PCI window reservations still intact. Isn't that a bisection
> problem? This patch should come before the iova list is expose to the
> user. This is otherwise independent, so I can pop it up in the stack on
> commit, but I'd need an ack from Joerg and Robin to take it via my
> tree. Thanks,
If it counts, the changes look right, so:
Acked-by: Robin Murphy <robin.murphy@arm.com>
but it does look like there's a hard dependency on Joerg's core branch
where Shameer's ITS workaround patches are currently queued. Otherwise,
though, I don't think there's anything else due to be touching iommu-dma
just yet.
Robin.
>
> Alex
>
>> drivers/iommu/dma-iommu.c | 54 ++++++++++++++++++++++-------------------------
>> 1 file changed, 25 insertions(+), 29 deletions(-)
>>
>> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
>> index f05f3cf..ddcbbdb 100644
>> --- a/drivers/iommu/dma-iommu.c
>> +++ b/drivers/iommu/dma-iommu.c
>> @@ -167,40 +167,16 @@ EXPORT_SYMBOL(iommu_put_dma_cookie);
>> * @list: Reserved region list from iommu_get_resv_regions()
>> *
>> * IOMMU drivers can use this to implement their .get_resv_regions callback
>> - * for general non-IOMMU-specific reservations. Currently, this covers host
>> - * bridge windows for PCI devices and GICv3 ITS region reservation on ACPI
>> - * based ARM platforms that may require HW MSI reservation.
>> + * for general non-IOMMU-specific reservations. Currently, this covers GICv3
>> + * ITS region reservation on ACPI based ARM platforms that may require HW MSI
>> + * reservation.
>> */
>> void iommu_dma_get_resv_regions(struct device *dev, struct list_head *list)
>> {
>> - struct pci_host_bridge *bridge;
>> - struct resource_entry *window;
>> -
>> - if (!is_of_node(dev->iommu_fwspec->iommu_fwnode) &&
>> - iort_iommu_msi_get_resv_regions(dev, list) < 0)
>> - return;
>> -
>> - if (!dev_is_pci(dev))
>> - return;
>> -
>> - bridge = pci_find_host_bridge(to_pci_dev(dev)->bus);
>> - resource_list_for_each_entry(window, &bridge->windows) {
>> - struct iommu_resv_region *region;
>> - phys_addr_t start;
>> - size_t length;
>> -
>> - if (resource_type(window->res) != IORESOURCE_MEM)
>> - continue;
>>
>> - start = window->res->start - window->offset;
>> - length = window->res->end - window->res->start + 1;
>> - region = iommu_alloc_resv_region(start, length, 0,
>> - IOMMU_RESV_RESERVED);
>> - if (!region)
>> - return;
>> + if (!is_of_node(dev->iommu_fwspec->iommu_fwnode))
>> + iort_iommu_msi_get_resv_regions(dev, list);
>>
>> - list_add_tail(®ion->list, list);
>> - }
>> }
>> EXPORT_SYMBOL(iommu_dma_get_resv_regions);
>>
>> @@ -229,6 +205,23 @@ static int cookie_init_hw_msi_region(struct iommu_dma_cookie *cookie,
>> return 0;
>> }
>>
>> +static void iova_reserve_pci_windows(struct pci_dev *dev,
>> + struct iova_domain *iovad)
>> +{
>> + struct pci_host_bridge *bridge = pci_find_host_bridge(dev->bus);
>> + struct resource_entry *window;
>> + unsigned long lo, hi;
>> +
>> + resource_list_for_each_entry(window, &bridge->windows) {
>> + if (resource_type(window->res) != IORESOURCE_MEM)
>> + continue;
>> +
>> + lo = iova_pfn(iovad, window->res->start - window->offset);
>> + hi = iova_pfn(iovad, window->res->end - window->offset);
>> + reserve_iova(iovad, lo, hi);
>> + }
>> +}
>> +
>> static int iova_reserve_iommu_regions(struct device *dev,
>> struct iommu_domain *domain)
>> {
>> @@ -238,6 +231,9 @@ static int iova_reserve_iommu_regions(struct device *dev,
>> LIST_HEAD(resv_regions);
>> int ret = 0;
>>
>> + if (dev_is_pci(dev))
>> + iova_reserve_pci_windows(to_pci_dev(dev), iovad);
>> +
>> iommu_get_resv_regions(dev, &resv_regions);
>> list_for_each_entry(region, &resv_regions, list) {
>> unsigned long lo, hi;
>
next prev parent reply other threads:[~2018-03-22 17:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 16:35 [PATCH v5 0/7] vfio/type1: Add support for valid iova list management Shameer Kolothum
2018-03-15 16:35 ` [PATCH v5 1/7] vfio/type1: Introduce iova list and add iommu aperture validity check Shameer Kolothum
2018-03-15 16:35 ` [PATCH v5 2/7] vfio/type1: Check reserve region conflict and update iova list Shameer Kolothum
2018-03-19 7:51 ` Tian, Kevin
2018-03-19 10:55 ` Shameerali Kolothum Thodi
2018-03-19 12:16 ` Tian, Kevin
2018-03-20 22:37 ` Alex Williamson
2018-03-21 3:30 ` Tian, Kevin
2018-03-21 16:31 ` Alex Williamson
2018-03-22 9:15 ` Shameerali Kolothum Thodi
2018-03-15 16:35 ` [PATCH v5 3/7] vfio/type1: Update iova list on detach Shameer Kolothum
2018-03-15 16:35 ` [PATCH v5 4/7] vfio/type1: check dma map request is within a valid iova range Shameer Kolothum
2018-03-15 16:35 ` [PATCH v5 5/7] vfio/type1: Add IOVA range capability support Shameer Kolothum
2018-03-15 16:35 ` [PATCH v5 6/7] vfio/type1: remove duplicate retrieval of reserved regions Shameer Kolothum
2018-03-15 16:35 ` [PATCH v5 7/7] iommu/dma: Move PCI window region reservation back into dma specific path Shameer Kolothum
2018-03-22 16:21 ` Alex Williamson
2018-03-22 17:22 ` Robin Murphy [this message]
2018-03-23 8:57 ` Shameerali Kolothum Thodi
2018-03-28 13:41 ` Shameerali Kolothum Thodi
2018-03-19 8:28 ` [PATCH v5 0/7] vfio/type1: Add support for valid iova list management Tian, Kevin
2018-03-19 10:54 ` Shameerali Kolothum Thodi
2018-03-19 12:12 ` Tian, Kevin
2018-03-20 22:55 ` Alex Williamson
2018-03-21 3:28 ` Tian, Kevin
2018-03-21 17:11 ` Alex Williamson
2018-03-22 9:10 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b481ba6-ffdd-fef1-12dc-f5eac8b589d5@arm.com \
--to=robin.murphy@arm.com \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).