From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751925AbcF2ISl (ORCPT ); Wed, 29 Jun 2016 04:18:41 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36019 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbcF2ISi (ORCPT ); Wed, 29 Jun 2016 04:18:38 -0400 Subject: Re: [PATCH 3/5] mmu: don't set the present bit unconditionally To: Xiao Guangrong , Bandan Das , kvm@vger.kernel.org References: <1467088360-10186-1-git-send-email-bsd@redhat.com> <1467088360-10186-4-git-send-email-bsd@redhat.com> <57733DD3.7040404@linux.intel.com> Cc: linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <3b4a6bb6-4364-b188-48da-be79c0dc7534@redhat.com> Date: Wed, 29 Jun 2016 10:18:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <57733DD3.7040404@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/06/2016 05:17, Xiao Guangrong wrote: >> >> +++ b/arch/x86/kvm/mmu.c >> @@ -2516,13 +2516,17 @@ static int set_spte(struct kvm_vcpu *vcpu, u64 >> *sptep, >> gfn_t gfn, kvm_pfn_t pfn, bool speculative, >> bool can_unsync, bool host_writable) >> { >> - u64 spte; >> + u64 spte = 0; >> int ret = 0; >> + struct kvm_mmu *context = &vcpu->arch.mmu; >> + bool execonly = !(context->guest_rsvd_check.bad_mt_xwr & >> + (1ull << VMX_EPT_EXECUTABLE_MASK)); > > Could we introduce a new field, say execonly, to "struct kvm_mmu"? > That would make the code be more clearer. Given how execonly is used, let's add shadow_present_mask instead. Paolo