From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23507C388F7 for ; Tue, 3 Nov 2020 17:32:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7494221FB for ; Tue, 3 Nov 2020 17:32:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728994AbgKCRc5 (ORCPT ); Tue, 3 Nov 2020 12:32:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:34838 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727869AbgKCRc5 (ORCPT ); Tue, 3 Nov 2020 12:32:57 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 97210ADE3; Tue, 3 Nov 2020 17:32:55 +0000 (UTC) Message-ID: <3b4b1d0765b39e96e4c4d1fc6f05e1178c486096.camel@suse.de> Subject: Re: [PATCH v1] PCI: brcmstb: variable is missing proper initialization From: Nicolas Saenz Julienne To: Florian Fainelli , Jim Quinlan , linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= Cc: Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Andrew Murray , Jeremy Linton , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Date: Tue, 03 Nov 2020 18:32:54 +0100 In-Reply-To: References: <20201102205712.23332-1-james.quinlan@broadcom.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-Y1BfcH8l7k1gAwSH6jtl" User-Agent: Evolution 3.36.5 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-Y1BfcH8l7k1gAwSH6jtl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2020-11-02 at 13:07 -0800, Florian Fainelli wrote: >=20 > On 11/2/2020 12:57 PM, Jim Quinlan wrote: > > The variable 'tmp' is used multiple times in the brcm_pcie_setup() > > function. One such usage did not initialize 'tmp' to the current value= of > > the target register. By luck the mistake does not currently affect > > behavior; regardless 'tmp' is now initialized properly. > >=20 > > Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controll= er driver") > > Suggested-by: Rafa=C5=82 Mi=C5=82ecki > > Signed-off-by: Jim Quinlan Acked-by: Nicolas Saenz Julienne --=-Y1BfcH8l7k1gAwSH6jtl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl+hlEYACgkQlfZmHno8 x/7UmQf/QEPoyFXEKqZEvSUKhQM/wfdxv7GdwSdzHkvNK1H0UhjOvBgJYgEz38So O3gjPjD9dhQjTzIk610uHdqhfX04slpJMKVsOKgyN6DOanBJsWrqBqlMuYVFjmnW 7ucizmbyUAN6/sQEDCARzSFQTY6a6ddZYZyEVGSggZtuTNZhIiez1KmLtV1Kp+Ot yMp6XeMF7l6FHzqLXtmrkwbiBZsMxgDIgCJNFbmXqX7G8p1086bTHmBTq642Pz1B VNVKu1woPrjipQJGoqud4x9CbdFMwVeDgRvnu2nqA+z5GopEPecUGXcNSWs8FFxv CNYhiQXtY9xjyhUmhCEeQkbLLKJEqQ== =Ssc4 -----END PGP SIGNATURE----- --=-Y1BfcH8l7k1gAwSH6jtl--