From: Randy Dunlap <rdunlap@infradead.org>
To: Vitaly Chikunov <vt@altlinux.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA
Date: Tue, 23 Apr 2019 13:20:30 -0700 [thread overview]
Message-ID: <3b74a3e8-d915-8ff3-186f-c5a774d00bc3@infradead.org> (raw)
In-Reply-To: <20190423162954.7859-1-vt@altlinux.org>
On 4/23/19 9:29 AM, Vitaly Chikunov wrote:
> Fix undefined symbol issue in ecrdsa_generic module when ASN1
> or OID_REGISTRY aren't enabled in the config by selecting these
> options for CRYPTO_ECRDSA.
>
> ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
> ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
My tools would prefer to see the diff at one tree level higher:
> ---
> crypto/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git crypto/Kconfig crypto/Kconfig
diff --git a/crypto/Kconfig b/crypto/Kconfig
for any spelling of a and b.
> index 4446833f6eca..3d056e7da65f 100644
> --- crypto/Kconfig
> +++ crypto/Kconfig
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
> @@ -264,6 +264,8 @@ config CRYPTO_ECRDSA
> select CRYPTO_ECC
> select CRYPTO_AKCIPHER
> select CRYPTO_STREEBOG
> + select OID_REGISTRY
> + select ASN1
> help
> Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012,
> RFC 7091, ISO/IEC 14888-3:2018) is one of the Russian cryptographic
>
--
~Randy
next prev parent reply other threads:[~2019-04-23 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 16:29 [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA Vitaly Chikunov
2019-04-23 20:20 ` Randy Dunlap [this message]
2019-04-25 7:52 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b74a3e8-d915-8ff3-186f-c5a774d00bc3@infradead.org \
--to=rdunlap@infradead.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).