From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759279AbcIWLUA (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Sep 2016 07:20:00 -0400
Received: from mout.web.de ([212.227.15.3]:57976 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757625AbcIWLT6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Sep 2016 07:19:58 -0400
Subject: Re: GPU-DRM-TILCDC: Less function calls in
 tilcdc_convert_slave_node() after error detection
To: Rob Clark <robdclark@gmail.com>
References: <566ABCD9.1060404@users.sourceforge.net>
 <2f3f7ad7-16a0-1dfb-d073-0d993cd767ee@users.sourceforge.net>
 <0be7fee0-64f7-fa02-0337-51376677343e@users.sourceforge.net>
 <e9b443c7-2947-46d5-462f-58c175b774bc@ti.com>
 <d9b20442-3f84-82bd-d600-e3045a21da99@users.sourceforge.net>
 <CAF6AEGsHS9P0XyVH=So9woCkp9u8mUgL1QrCFNzgWdy26_4rDw@mail.gmail.com>
Cc: Jyri Sarha <jsarha@ti.com>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Julia Lawall <julia.lawall@lip6.fr>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <3b791118-2977-f607-b816-dd5e833cfc75@users.sourceforge.net>
Date: Fri, 23 Sep 2016 13:19:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <CAF6AEGsHS9P0XyVH=So9woCkp9u8mUgL1QrCFNzgWdy26_4rDw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:YI6Eu8FMx6Tse0jRdI88S+YsXui69F0ymO5msjlFA9DAoAHEkln
 ZULLLRBOhkIy9c3gPKMPNSUv82kJijlxFOUh2+Mc6YMi2vVSx3qgu4pmelRAfkj5Y+QiOtd
 zFPxnPB/dNJ4DNmGT5SI9/qxHNHXNuc/ByN16dCR8OaBAk2lCUCSWqVDnsIMB/tekCt1Hi0
 RW9fqUYm885NG/Er8vC/g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:TtJjD4pkwX0=:BYzQawuzY55jZxEBm7kfi3
 GHKFRl7g+Gc6dGcP/TUJfiU1Ni45e/EiB04q2kFigum2ridK/X5tuG5YvQoeuVlme8q2PLYzX
 TLFf7ERoQl8F/Gbxe6kMC5xC266ewhcHUfykUksw6kUH3V48D6vNE2+tsQZBfmGpn276/Yj+1
 8oz7DGm26gVGtJHnei39Yk2AhAJsKwXkWA/Wf9YXSxLvKxvfY5aM4jPHLiYULDybIboYS5ou9
 NszAo26leOWiCf19dhotO/tkw19fNbdaK5akv2RUavei5QulOJCgrVZXS3MFEd5MJIuungsI1
 8uXvqs4sTOKKoZh1BbqcHa9CpOMstuF+0d9Xw8LyIAR7BNAe8caplBtkSvTWrGfyp9GoufO8m
 +JIuK8gkS/KUh5/t1CwV4+W2gPe/IgCpK4Du+516bNcBnfzMQcmeVP7haf6R623gOH6Nuitk7
 cdntG8+JUTNhL6tL0xePh5kWr4te4udFRGsK+SzXoMHIoWfp4gCmmGrNrTcBoBKp6LyZsoFNs
 wqSWoGgPex7yc9P+BnR2sRdDTCKIxJRFZn4FncMqvuyVYrjUY/05tL2AQvrftASOCA0C2PS3V
 XDF+2U8Gv43dlHRKjKiBHpuvqPnMBrJCnowmMSLaNolMrLS2TE6gJBwXhomJh2WSEOSBxDcqZ
 Webpl9/TdadIWxBYzOwPOv1Q/xrhYwm4QU4bPlOGqFpiaeAbM+uGC6fKjBiH1ZJ+7i0XoE3Fe
 eF6GDZpcoHDT5+MISR7GsFMK24/NeJao3OrT/S80ZEjh5GwOyi0qVL77QsU17drxaCCcjron7
 cOXSZel
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> iirc, there are Coccinelle rules that find code with unnecessary null
> checks and removes them.

This kind of software change is not needed here.

I find that a corresponding return value check happens one function call
too late.


> Although you probably made this complex enough that cocinelle would
> not find it.  That is not a complement.

I imagine that scripts for the semantic patch language can find more
source code places where questionable disjunctions are used so far.
Would you dare to split any more condition checks?


> One should not make error handling/cleanup more complex than needed.

I see a need to improve not only correctness there but also a bit of
software efficiency.

Regards,
Markus