linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: yangshukui <yangshukui@huawei.com>
To: <dwmw2@infradead.org>, <linux-mtd@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] fs/jffs2: Fix a Invalid argument error when mkdir in jffs2 which is mounted as overlayfs
Date: Wed, 14 Jun 2017 14:30:30 +0800	[thread overview]
Message-ID: <3b8362cf-da22-fbb0-de80-9f9bf8ec4326@huawei.com> (raw)
In-Reply-To: <58B689F1.3000000@huawei.com>

In jffs2 filesystem, I mount a overlayfs, after rmdir  and mkdir, 
'Invalid argument' error will appear.
It can be reproduced like this,

[root@localhost mnt]# mkdir -p overlay-mkdir
[root@localhost overlay-mkdir]# pwd;mount|grep jffs2
/root/mnt/overlay-mkdir
/dev/mtdblock0 on /root/mnt type jffs2 (rw,relatime)

[root@localhost mnt]# cd overlay-mkdir/
[root@localhost overlay-mkdir]# mkdir -p merged  lower/hello  upper work
[root@localhost overlay-mkdir]# mount -t overlay overlay 
-olowerdir=lower,upperdir=upper,workdir=work merged
[root@localhost overlay-mkdir]# rmdir merged/hello
[root@localhost overlay-mkdir]# mkdir merged/hello
mkdir: cannot create directory merged/hello Invalid argument

From: Shukui Yang <yangshukui@huawei.com>
Date: Wed, 14 Jun 2017 14:03:51 +0800
Subject: [PATCH] fs/jffs2: fix a Invalid argument error when mkdir in 
jffs2 which is
  mounted as overlayfs

Signed-off-by:  Shukui Yang <yangshukui@huawei.com>
---
  fs/jffs2/dir.c | 11 ++++++++---
  1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c
index cfbceb1..9a95d98 100644
--- a/fs/jffs2/dir.c
+++ b/fs/jffs2/dir.c
@@ -34,8 +34,8 @@ static int jffs2_symlink (struct inode *,struct dentry 
*,const char *);
  static int jffs2_mkdir (struct inode *,struct dentry *,umode_t);
  static int jffs2_rmdir (struct inode *,struct dentry *);
  static int jffs2_mknod (struct inode *,struct dentry *,umode_t,dev_t);
-static int jffs2_rename (struct inode *, struct dentry *,
-                        struct inode *, struct dentry *);
+static int jffs2_rename2 (struct inode *, struct dentry *,
+                        struct inode *, struct dentry *, unsigned int);

  const struct file_operations jffs2_dir_operations =
  {
@@ -57,7 +57,7 @@ const struct inode_operations jffs2_dir_inode_operations =
         .mkdir =        jffs2_mkdir,
         .rmdir =        jffs2_rmdir,
         .mknod =        jffs2_mknod,
-       .rename =       jffs2_rename,
+       .rename2 =      jffs2_rename2,
         .get_acl =      jffs2_get_acl,
         .set_acl =      jffs2_set_acl,
         .setattr =      jffs2_setattr,
@@ -865,3 +865,8 @@ static int jffs2_rename (struct inode *old_dir_i, 
struct dentry *old_dentry,
         return 0;
  }

+static int jffs2_rename2 (struct inode *old_dir_i, struct dentry 
*old_dentry,
+                        struct inode *new_dir_i, struct dentry 
*new_dentry, unsigned int flags)
+{
+       return jffs2_rename(old_dir_i, old_dentry, new_dir_i, new_dentry);
+}
-- 
2.6.2

  parent reply	other threads:[~2017-06-14  6:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01  8:44 Bug fix for uid/gid in jffs2 yangshukui
2017-03-01  9:29 ` David Woodhouse
2017-06-14  6:30 ` yangshukui [this message]
2017-06-14 15:55   ` [PATCH] fs/jffs2: Fix a Invalid argument error when mkdir in jffs2 which is mounted as overlayfs Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b8362cf-da22-fbb0-de80-9f9bf8ec4326@huawei.com \
    --to=yangshukui@huawei.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).