From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-watchdog@vger.kernel.org,
"Günter Röck" <linux@roeck-us.net>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH] watchdog/ie6xx_wdt: Combine two seq_printf() calls into one call in ie6xx_wdt_dbg_show()
Date: Sat, 13 Jan 2018 13:50:50 +0100 [thread overview]
Message-ID: <3b9880f2-2c21-8574-7659-74bc8e211852@users.sourceforge.net> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 13 Jan 2018 13:45:35 +0100
Some data were printed into a sequence by two separate function calls.
Print the same data by a single function call instead.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/watchdog/ie6xx_wdt.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/watchdog/ie6xx_wdt.c b/drivers/watchdog/ie6xx_wdt.c
index 78c2541f5d52..f2963cb21df7 100644
--- a/drivers/watchdog/ie6xx_wdt.c
+++ b/drivers/watchdog/ie6xx_wdt.c
@@ -205,10 +205,8 @@ static int ie6xx_wdt_dbg_show(struct seq_file *s, void *unused)
inw(ie6xx_wdt_data.sch_wdtba + WDTCR));
seq_printf(s, "DCR = 0x%08x\n",
inl(ie6xx_wdt_data.sch_wdtba + DCR));
- seq_printf(s, "WDTLR = 0x%08x\n",
- inw(ie6xx_wdt_data.sch_wdtba + WDTLR));
-
- seq_printf(s, "\n");
+ seq_printf(s, "WDTLR = 0x%08x\n\n",
+ inw(ie6xx_wdt_data.sch_wdtba + WDTLR));
return 0;
}
--
2.15.1
reply other threads:[~2018-01-13 12:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b9880f2-2c21-8574-7659-74bc8e211852@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).