From: Elon Zhang <zhangzj@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: mark.rutland@arm.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v1 1/1] ARM: dts: rockchip: set crypto default disabled on rk3288
Date: Thu, 29 Aug 2019 19:31:00 +0800 [thread overview]
Message-ID: <3b9cbffa-291e-fc95-bce6-5b24f5fd860d@rock-chips.com> (raw)
In-Reply-To: <4806912.UyKsYhR33o@phil>
Hi Heiko,
On 8/27/2019 22:28, Heiko Stuebner wrote:
> Hi,
>
> Am Dienstag, 27. August 2019, 09:14:39 CEST schrieb Elon Zhang:
>> Not every board needs to enable crypto node, so the node should
>> be set default disabled in rk3288.dtsi and enabled in specific
>> board dts file.
> Can you give a bit more rationale here? There would need to be a very
> specific reason because of the following:
>
> The crypto module is not wired to some board-specific components,
> so its usability does not depend on the specific board at all.
> Instead every board can just use it out of the box and the devicetree
> is supposed to describe the hardware and is _not_ meant as a space
> for user configuration.
Right for almost all normal hardware modules but the crypto module was
designed
for secure world. As a result, the crypto module will become
inaccessible for linux
kernel if secure world enable it.
We plan to enable the crypto module in secure world so we should set
crypto module
default disabled in linux kernel.
>
> So in fact the status property should probably go away completely from
> the crypto node, as it's usable out of the box in all cases.
>
>
> Heiko
>
>
>
>> Signed-off-by: Elon Zhang <zhangzj@rock-chips.com>
>> ---
>> arch/arm/boot/dts/rk3288.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index cc893e154fe5..d509aa24177c 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -984,7 +984,7 @@
>> clock-names = "aclk", "hclk", "sclk", "apb_pclk";
>> resets = <&cru SRST_CRYPTO>;
>> reset-names = "crypto-rst";
>> - status = "okay";
>> + status = "disabled";
>> };
>>
>> iep_mmu: iommu@ff900800 {
>>
>
>
>
>
>
>
next prev parent reply other threads:[~2019-08-29 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 7:14 [PATCH v1 1/1] ARM: dts: rockchip: set crypto default disabled on rk3288 Elon Zhang
2019-08-27 14:28 ` Heiko Stuebner
2019-08-29 11:31 ` Elon Zhang [this message]
2019-08-31 23:04 ` Heiko Stuebner
2019-09-10 2:45 ` Elon Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b9cbffa-291e-fc95-bce6-5b24f5fd860d@rock-chips.com \
--to=zhangzj@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).