LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Stephen Boyd <swboyd@chromium.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
	Julia Lawall <Julia.Lawall@lip6.fr>,
	linux-kernel@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Mark Brown <broonie@kernel.org>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Rob Herring <robh@kernel.org>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [v4 3/3] coccinelle: Add script to check for platform_get_irq() excessive prints
Date: Wed, 24 Jul 2019 20:38:48 +0200
Message-ID: <3baa3e3c-c122-e868-55a0-597e279496ac@web.de> (raw)
In-Reply-To: <5d38a1c3.1c69fb81.2b26a.b585@mx.google.com>

>>> +if (ret != -EPROBE_DEFER)
>>
>> Is it appropriate to treat this error code check as optional
>> by the shown transformation approach?
>> Can this case distinction be omitted?
>
> I don't know what you mean here.

I suggest to take another look at the importance and relevance
of this specific source code search detail (including SmPL disjunctions).


> Do you want me to drop this part so that EPROBE_DEFER checks don't get removed?

No, not at the moment. - But I am still looking for further clarification
of the desired software design.
So I am curious how a corresponding agreement will evolve.

Regards,
Markus

  reply index

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 18:16 [PATCH v4 0/3] Add error message to platform_get_irq*() Stephen Boyd
2019-07-23 18:16 ` [PATCH v4 1/3] driver core: platform: Add an " Stephen Boyd
2019-07-24 15:00   ` Markus Elfring
2019-07-24 18:17     ` Stephen Boyd
2019-07-25  5:55   ` Markus Elfring
2019-07-23 18:16 ` [PATCH v4 2/3] treewide: Remove dev_err() usage after platform_get_irq() Stephen Boyd
2019-07-23 18:31   ` Andy Shevchenko
2019-07-23 22:23     ` Stephen Boyd
2019-07-24 11:17       ` [v4 " Markus Elfring
2019-07-23 19:30   ` [PATCH v4 " Rob Herring
2019-07-23 22:24     ` Stephen Boyd
2019-07-24 17:08       ` Mark Brown
2019-07-24  6:35   ` Greg Kroah-Hartman
2019-07-24 17:06   ` Mark Brown
2019-07-23 18:16 ` [PATCH v4 3/3] coccinelle: Add script to check for platform_get_irq() excessive prints Stephen Boyd
2019-07-24  9:30   ` Markus Elfring
2019-07-24 18:21     ` Stephen Boyd
2019-07-24 18:38       ` Markus Elfring [this message]
2019-07-24 13:18   ` Markus Elfring
2019-07-24 18:23     ` Stephen Boyd
2019-07-24 18:45       ` [v4 " Markus Elfring

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3baa3e3c-c122-e868-55a0-597e279496ac@web.de \
    --to=markus.elfring@web.de \
    --cc=Gilles.Muller@lip6.fr \
    --cc=Julia.Lawall@lip6.fr \
    --cc=a.hajda@samsung.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=cocci@systeme.lip6.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=javierm@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robh@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox