From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA8A2C433B4 for ; Mon, 10 May 2021 13:07:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF2D1611BD for ; Mon, 10 May 2021 13:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235762AbhEJNHt (ORCPT ); Mon, 10 May 2021 09:07:49 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44302 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237081AbhEJNEh (ORCPT ); Mon, 10 May 2021 09:04:37 -0400 Received: from mail-qk1-f200.google.com ([209.85.222.200]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lg5ZB-0007DP-BS for linux-kernel@vger.kernel.org; Mon, 10 May 2021 13:03:21 +0000 Received: by mail-qk1-f200.google.com with SMTP id p17-20020a05620a1131b02902e45c6e4d33so11600266qkk.0 for ; Mon, 10 May 2021 06:03:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MbGqG1sl2bPlNa6+74LoXiACLGc6BiOtk88NxsSE+AY=; b=BIK8VttramTVSznKlIT4eEi/nZxATDyzT9onfKEB8FQAqih989d4OqArrXHiL0k4rd a5mjs3IHrAcB6LbzHvxFvs603RmOAOeYXOCLd4JXAiom9AhHtyOpYgAuvbI/UxusuXQs by0M+4ZsVdfXiPk4OeP1WIoqmVXS+s/JgTx46mS1haNvviZ8nTINbSjMOlLrbByf8fcN g4tcRrYC1Y34aGUKJGszpkcIAHv1jVk4brybpQIQScpfQw2YPpbAxFfdRabTryhorRm0 lFT+SI+CdRLJCK09uS6Iyht1P0FT9L6d6TSFXVp02PRttM/Ii67c3mbKPlSXiuWHlowh PXAA== X-Gm-Message-State: AOAM533Wzr1aQAusQz5UrM4p9HF0mRpo9vmxUrOcXyN04T5QsirFjH3F 9c82Kc/AfBs4IXJpQZ4kdh5eGWbScTrKiQQg7bSwoZJIlQJn1nWNjQUSorwClwp9WHcvsw+/sSG HS9T7FPZixFaSjGXqtS1wcB9rf99ABHL092e03OEXxA== X-Received: by 2002:a05:620a:15f7:: with SMTP id p23mr21786084qkm.178.1620651800142; Mon, 10 May 2021 06:03:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzd8s28LSxq8tUMy7z9+LnTPfJPs32ao6LYW4bs5JpkeVNJFE9Gh7LFTqRifB+Q6AdPYAjS0w== X-Received: by 2002:a05:620a:15f7:: with SMTP id p23mr21786045qkm.178.1620651799761; Mon, 10 May 2021 06:03:19 -0700 (PDT) Received: from [192.168.1.4] ([45.237.49.1]) by smtp.gmail.com with ESMTPSA id q13sm11608797qkj.43.2021.05.10.06.03.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 06:03:18 -0700 (PDT) Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl To: Mark Kettenis , devicetree@vger.kernel.org Cc: Hector Martin , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210508142000.85116-1-kettenis@openbsd.org> <20210508142000.85116-2-kettenis@openbsd.org> From: Krzysztof Kozlowski Message-ID: <3bad54b9-599a-91c6-48b8-dd1c494f61b5@canonical.com> Date: Mon, 10 May 2021 09:03:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210508142000.85116-2-kettenis@openbsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/2021 10:19, Mark Kettenis wrote: > The Apple GPIO controller is a simple combined pin and GPIO conroller > present on Apple ARM SoC platforms, including various iPhone and iPad > devices and the "Apple Silicon" Macs. > > Signed-off-by: Mark Kettenis > --- > .../bindings/pinctrl/apple,pinctrl.yaml | 103 ++++++++++++++++++ > MAINTAINERS | 2 + > include/dt-bindings/pinctrl/apple.h | 13 +++ > 3 files changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > create mode 100644 include/dt-bindings/pinctrl/apple.h > > diff --git a/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > new file mode 100644 > index 000000000000..cc7805ca6ba1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > @@ -0,0 +1,103 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/apple,pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple GPIO controller > + > +maintainers: > + - Mark Kettenis > + > +description: | > + The Apple GPIO controller is a simple combined pin and GPIO conroller > + present on Apple ARM SoC platforms, including various iPhone and iPad > + devices and the "Apple Silicon" Macs. > + > +properties: > + compatible: > + items: > + - const: apple,t8103-pinctrl > + - const: apple,pinctrl What is the point of having very generic final compatible in the binding which does not relate to actual hardware? Let's say next SoC will be apple,x-abcd-foo-2323-whatever-nothing-in-common and you still have to use generic "apple,pinctrl" even though HW is not at all compatible? This looks like wildcard, not HW description. Best regards, Krzysztof