From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72C9C433F5 for ; Mon, 13 Sep 2021 20:55:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA4B8610A2 for ; Mon, 13 Sep 2021 20:55:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241958AbhIMU5F (ORCPT ); Mon, 13 Sep 2021 16:57:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240999AbhIMU5D (ORCPT ); Mon, 13 Sep 2021 16:57:03 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9BBAC061574 for ; Mon, 13 Sep 2021 13:55:47 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id l16-20020a9d6a90000000b0053b71f7dc83so15207074otq.7 for ; Mon, 13 Sep 2021 13:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xlOUwRVv/SaM1ZoZrctrKFCQwOAIgRDrG+ihv2UpfRE=; b=hYpUq2fYnjWl98QExTA1Lcm3pKldkQlsz03K4Ceni+OVd4yS3nuQbH84FXn9mymrvU FHRAjNULnrb8zqGIaQf3IZLCJr1mdoFuMD8T8azOCroNQE2U0Z7jCawqQPmCMsajotSH o9p4ellOkdxtgZIeg0x3L9x1+ZZ6Dwtoj/LrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xlOUwRVv/SaM1ZoZrctrKFCQwOAIgRDrG+ihv2UpfRE=; b=awub2N6MbTQI8YTgFNCFxFF6hqwowqlQp9bQsxXv7MYds0UYMHMhjFvw3V359s3N8J 5R6BHwUABeim8sASjAQh3y9opjTm4whWJhMX3TtVib906EMQHzwuOSRAwjbH7BwKsOMr T9rZEk4RobpuhyZzd5Zfp+oazVgpNjmGX5DKtbCoZIeBJx4tPi/Py6F0kKCQXCKAi3TJ npJsgBP30o4MZQME+zOMOpdVYv4R4Vel4wtjnmnHGd662KY7ZO3CEd3qcMPfB70jlleF CTGYVVGW13o52o+CIqzjZTPjbeZf+GHDiJ2GeFNg+q6OlzxFgdlJkJ726+FX0CnrI+4I RA0Q== X-Gm-Message-State: AOAM532BRHnCG4JgNbUUHfT1d53NhTCtuXcNEcx5N9z6xeRn9h+x4SMq CXF76iHtR5MzDAdgXOI4y/0ysw== X-Google-Smtp-Source: ABdhPJxX6VLJs0ZE/xnRItZvUlnzABjm694fEoRvXc78iBIISqm0Sa0k2us+ag+7HT07CwsTKbCfmQ== X-Received: by 2002:a05:6830:818:: with SMTP id r24mr11477370ots.2.1631566547004; Mon, 13 Sep 2021 13:55:47 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id z1sm2139510ooj.25.2021.09.13.13.55.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 13:55:46 -0700 (PDT) Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] To: Brendan Higgins , Arnd Bergmann Cc: Linus Torvalds , Naresh Kamboju , Mathias Nyman , Johannes Berg , Jakub Kicinski , Ariel Elior , GR-everest-linux-l2@marvell.com, Wei Liu , Linux ARM , open list , Netdev , lkft-triage@lists.linaro.org, "David S. Miller" , Greg Kroah-Hartman , Nick Desaulniers , Nathan Chancellor , Daniel Borkmann , Alexei Starovoitov , Eric Dumazet , KUnit Development , Shuah Khan References: <36aa5cb7-e3d6-33cb-9ac6-c9ff1169d711@linuxfoundation.org> <120389b9-f90b-0fa3-21d5-1f789b4c984d@linuxfoundation.org> From: Shuah Khan Message-ID: <3bad5d2f-8ce7-d0b9-19ad-def68d4193dd@linuxfoundation.org> Date: Mon, 13 Sep 2021 14:55:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/8/21 3:24 PM, Brendan Higgins wrote: > On Wed, Sep 8, 2021 at 10:16 AM Shuah Khan wrote: >> >> On 9/8/21 11:05 AM, Arnd Bergmann wrote: >>> On Wed, Sep 8, 2021 at 4:12 PM Shuah Khan wrote: >>>> On 9/7/21 5:14 PM, Linus Torvalds wrote: >>>>> The KUNIT macros create all these individually reasonably small >>>>> initialized structures on stack, and when you have more than a small >>>>> handful of them the KUNIT infrastructure just makes the stack space >>>>> explode. Sometimes the compiler will be able to re-use the stack >>>>> slots, but it seems to be an iffy proposition to depend on it - it >>>>> seems to be a combination of luck and various config options. >>>>> >>>> >>>> I have been concerned about these macros creeping in for a while. >>>> I will take a closer look and work with Brendan to come with a plan >>>> to address it. >>> >>> I've previously sent patches to turn off the structleak plugin for >>> any kunit test file to work around this, but only a few of those patches >>> got merged and new files have been added since. It would >>> definitely help to come up with a proper fix, but my structleak-disable >>> hack should be sufficient as a quick fix. >>> >> >> Looks like these are RFC patches and the discussion went cold. Let's pick >> this back up and we can make progress. >> >> https://lore.kernel.org/lkml/CAFd5g45+JqKDqewqz2oZtnphA-_0w62FdSTkRs43K_NJUgnLBg@mail.gmail.com/ > > I can try to get the patch reapplying and send it out (I just figured > that Arnd or Kees would want to send it out :-) since it was your > idea). > Brendan, Would you like to send me the fix with Suggested-by for Arnd or Kees? thanks, -- Shuah