From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E44FC64990 for ; Thu, 25 Aug 2022 07:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237027AbiHYHG3 (ORCPT ); Thu, 25 Aug 2022 03:06:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236566AbiHYHGZ (ORCPT ); Thu, 25 Aug 2022 03:06:25 -0400 Received: from comms.puri.sm (comms.puri.sm [159.203.221.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC1B96D56F; Thu, 25 Aug 2022 00:06:22 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id D1C31E11BC; Thu, 25 Aug 2022 00:06:22 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F9caSXysCpjt; Thu, 25 Aug 2022 00:06:21 -0700 (PDT) Message-ID: <3bbba64dc4fd9ef37fb937f5176b1ef50b8b2d73.camel@puri.sm> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1661411181; bh=XXMdNjo3qg/zPAEYx0MvDsz7VX60NpEYc1P2Apa2KLg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=XXRksyTmgBWWhkfMl7wCBMuh5oHkadhmqnIQmaIPor/McqME4jCPoy05sOKeDBJO7 uU0EnhlA5MKoFot2jWgs/EL9NeGhkFmgPt+vzdv89nlSNWubaVdY1hseomLiSBfr6Q Qe+MMW1yQnBtlVaQDtCjiNqEe5Nbu9GDNjxveKskL4Hvf7xQc0CCtjtXq9KQvuxbmB uEeKlSgd36/hG4Z/Xb576arZvDPyBHAvzUl/3CVEn6QVUfNh/C58/vbrlB6THawxb6 EC+HacR04H7426ty9W+rWcs4cwD3wQxLBtoNAUBWV3kRcXl5a1758piIX5nZSx0tRr ajJAi8WDlhkpA== Subject: Re: [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts From: Martin Kepplinger To: Ulf Hansson Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Thu, 25 Aug 2022 09:06:16 +0200 In-Reply-To: References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-2-martin.kepplinger@puri.sm> <77baacb930bf2ba1a65cb1515e6795b48d2d4ed5.camel@puri.sm> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, dem 24.08.2022 um 15:30 +0200 schrieb Ulf Hansson: > On Mon, 22 Aug 2022 at 10:38, Martin Kepplinger > wrote: > > > > Am Freitag, dem 19.08.2022 um 16:53 +0200 schrieb Ulf Hansson: > > > On Fri, 19 Aug 2022 at 11:17, Martin Kepplinger > > > wrote: > > > > > > > > Am Dienstag, dem 26.07.2022 um 17:07 +0200 schrieb Ulf Hansson: > > > > > On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger > > > > > wrote: > > > > > > > > > > > > If for example the power-domains' power-supply node > > > > > > (regulator) > > > > > > needs > > > > > > interrupts to work, the current setup with noirq callbacks > > > > > > cannot > > > > > > work; for example a pmic regulator on i2c, when suspending, > > > > > > usually > > > > > > already > > > > > > times out during suspend_noirq: > > > > > > > > > > > > [   41.024193] buck4: failed to disable: -ETIMEDOUT > > > > > > > > > > > > So fix system suspend and resume for these power-domains by > > > > > > using > > > > > > the > > > > > > "outer" suspend/resume callbacks instead. Tested on the > > > > > > imx8mq- > > > > > > librem5 board, > > > > > > but by looking at the dts, this will fix imx8mq-evk and > > > > > > possibly > > > > > > many other > > > > > > boards too. > > > > > > > > > > > > This is designed so that genpd providers just say "this > > > > > > genpd > > > > > > needs > > > > > > interrupts" (by setting the flag) - without implying an > > > > > > implementation. > > > > > > > > > > > > Initially system suspend problems had been discussed at > > > > > > https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/ > > > > > > which led to discussing the pmic that contains the > > > > > > regulators > > > > > > which > > > > > > serve as power-domain power-supplies: > > > > > > https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/ > > > > > > > > > > > > Signed-off-by: Martin Kepplinger > > > > > > > > > > > > --- > > > > > >  drivers/base/power/domain.c | 13 +++++++++++-- > > > > > >  include/linux/pm_domain.h   |  5 +++++ > > > > > >  2 files changed, 16 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/drivers/base/power/domain.c > > > > > > b/drivers/base/power/domain.c > > > > > > index 5a2e0232862e..58376752a4de 100644 > > > > > > --- a/drivers/base/power/domain.c > > > > > > +++ b/drivers/base/power/domain.c > > > > > > @@ -130,6 +130,7 @@ static const struct genpd_lock_ops > > > > > > genpd_spin_ops = { > > > > > >  #define genpd_is_active_wakeup(genpd)  (genpd->flags & > > > > > > GENPD_FLAG_ACTIVE_WAKEUP) > > > > > >  #define genpd_is_cpu_domain(genpd)     (genpd->flags & > > > > > > GENPD_FLAG_CPU_DOMAIN) > > > > > >  #define genpd_is_rpm_always_on(genpd)  (genpd->flags & > > > > > > GENPD_FLAG_RPM_ALWAYS_ON) > > > > > > +#define genpd_irq_on(genpd)            (genpd->flags & > > > > > > GENPD_FLAG_IRQ_ON) > > > > > > > > > > > >  static inline bool irq_safe_dev_in_sleep_domain(struct > > > > > > device > > > > > > *dev, > > > > > >                 const struct generic_pm_domain *genpd) > > > > > > @@ -2065,8 +2066,15 @@ int pm_genpd_init(struct > > > > > > generic_pm_domain > > > > > > *genpd, > > > > > >         genpd->domain.ops.runtime_suspend = > > > > > > genpd_runtime_suspend; > > > > > >         genpd->domain.ops.runtime_resume = > > > > > > genpd_runtime_resume; > > > > > >         genpd->domain.ops.prepare = genpd_prepare; > > > > > > -       genpd->domain.ops.suspend_noirq = > > > > > > genpd_suspend_noirq; > > > > > > -       genpd->domain.ops.resume_noirq = > > > > > > genpd_resume_noirq; > > > > > > + > > > > > > +       if (genpd_irq_on(genpd)) { > > > > > > +               genpd->domain.ops.suspend = > > > > > > genpd_suspend_noirq; > > > > > > +               genpd->domain.ops.resume = > > > > > > genpd_resume_noirq; > > > > > > +       } else { > > > > > > +               genpd->domain.ops.suspend_noirq = > > > > > > genpd_suspend_noirq; > > > > > > +               genpd->domain.ops.resume_noirq = > > > > > > genpd_resume_noirq; > > > > > > > > > > As we discussed previously, I am thinking that it may be > > > > > better > > > > > to > > > > > move to using genpd->domain.ops.suspend_late and > > > > > genpd->domain.ops.resume_early instead. > > > > > > > > Wouldn't that better be a separate patch (on top)? Do you > > > > really > > > > want > > > > me to change the current behaviour (default case) to from noirq > > > > to > > > > late? Then I'll resend this series with such a patch added. > > > > > > Sorry, I wasn't clear enough, the default behaviour should remain > > > as > > > is. > > > > > > What I meant was, when genpd_irq_on() is true, we should use the > > > genpd->domain.ops.suspend_late and genpd- > > > >domain.ops.resume_early. > > > > Testing that shows that this isn't working. I can provide the logs > > later, but suspend fails and I think it makes sense: "suspend_late" > > is > > simply already too late when i2c (or any needed driver) uses > > "suspend". > > Okay, I see. > > The reason why I suggested moving the callbacks to "suspend_late", > was > that I was worried that some of the attached devices to genpd could > use "suspend_late" themselves. This is the case for some drivers for > DMA/clock/gpio/pinctrl-controllers, for example. That said, I am > curious to look at the DT files for the platform you are running, > would you mind giving me a pointer? I'm running https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi with these (small) patches on top: https://source.puri.sm/martin.kepplinger/linux-next/-/commits/5.19.3/librem5 > > So, this made me think about this a bit more. In the end, just using > different levels (suspend, suspend_late, suspend_noirq) of callbacks > are just papering over the real *dependency* problem. true, it doesn't feel like a stable solution. > > What we need for the genpd provider driver, is to be asked to be > suspended under the following conditions: > 1. All consumer devices (and child-domains) for its corresponding PM > domain have been suspended. > 2. All its supplier devices supplies must remain resumed, until the > genpd provider has been suspended. > > Please allow me a few more days to think in more detail about this. Thanks a lot for thinking about this! > > In some way, it looks like we should be able to combine the > information genpd has about its devices and child-domains, use PM > callbacks for the genpd provider driver - so we can rely on the > depency-path the fw_devlinks would give us for its supplier devices. > > Kind regards > Uffe martin