Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property

From: Philippe CORNU <philippe.cornu@st.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	David Airlie <airlied@linux.ie>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	Mickael REULIER <mickael.reulier@st.com>,
	Russell King <linux@armlinux.org.uk>,
	"Fabien DESSENNE" <fabien.dessenne@st.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Vincent ABRIOU <vincent.abriou@st.com>,
	Ludovic BARRE <ludovic.barre@st.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Yannick FERTRE <yannick.fertre@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
	Bhumika Goyal <bhumirks@gmail.com>
Subject: Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property
Date: Sun, 21 Jan 2018 21:15:54 +0000	[thread overview]
Message-ID: <3bd6bddd-db0d-2b5e-a676-2d56b7e5ca41@st.com> (raw)
In-Reply-To: <20180119224335.exrxcfq3xc6op6iy@rob-hp-laptop>

Hi Rob,

On 01/19/2018 11:43 PM, Rob Herring wrote:
> On Fri, Jan 12, 2018 at 04:30:34PM +0100, Philippe Cornu wrote:
>> Add the DPI/RGB input pixel clock in mandatory properties
>> because it really offers a better preciseness for timing
>> computations.
>> Note: Fix also the DSI panel example where "ref" & "pclk"
>> clocks were swapped.
>>
>> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
>> ---
>> Changes in v2: put new clock in last position (Rob Herring)
>>
>>   Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> index 029252253ad4..942b7237ae87 100644
>> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
>> @@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI:
>>   - compatible: "st,stm32-dsi".
>>   - clock-names:
>>     - phy pll reference clock string name, must be "ref".
>> +  - DPI/RGB input pixel clock string name, must be "px_clk".
>>   - resets: see [5].
>>   - reset-names: see [5].
>>   
>> @@ -97,8 +98,9 @@ Example 2: DSI panel
>>   			#size-cells = <0>;
>>   			compatible = "st,stm32-dsi";
>>   			reg = <0x40016c00 0x800>;
>> -			clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
>> -			clock-names = "ref", "pclk";
>> +			clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>,
>> +				 <&rcc 1 CLK_LCD>;
>> +			clock-names = "pclk", "ref", "px_clk";
> 
> You have the existing names reversed here.

And many thanks for your review.

Names are "reversed" as explained in the note in the commit message.

Well, maybe the note is not clear enough... So I have just sent 2 
separate patches that I hope will be better to understand.

Many thanks,
Philippe : )

> 
>>   			resets = <&rcc STM32F4_APB2_RESET(DSI)>;
>>   			reset-names = "apb";
>>   
>> -- 
>> 2.15.1
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 