From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936584AbcLOPVF (ORCPT ); Thu, 15 Dec 2016 10:21:05 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:41040 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933463AbcLOPVE (ORCPT ); Thu, 15 Dec 2016 10:21:04 -0500 Subject: Re: [PATCHv13 2/3] usb: USB Type-C connector class To: Heikki Krogerus , Oliver Neukum References: <20161124122144.26259-1-heikki.krogerus@linux.intel.com> <20161124122144.26259-3-heikki.krogerus@linux.intel.com> <20161129162744.GA2255@kroah.com> <20161130091910.GD32668@kuha.fi.intel.com> <20161202180439.GA25991@roeck-us.net> <1481104008.1960.3.camel@suse.com> <20161207125231.GB11966@kuha.fi.intel.com> <20161215115055.GB8312@kuha.fi.intel.com> Cc: Greg KH , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: Guenter Roeck Message-ID: <3bebbcd8-2401-abb3-4ada-e7c01ef805dd@roeck-us.net> Date: Thu, 15 Dec 2016 07:01:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161215115055.GB8312@kuha.fi.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/2016 03:50 AM, Heikki Krogerus wrote: > On Wed, Dec 07, 2016 at 02:52:31PM +0200, Heikki Krogerus wrote: >> Hi Oliver, >> >> On Wed, Dec 07, 2016 at 10:46:48AM +0100, Oliver Neukum wrote: >>> On Fri, 2016-12-02 at 10:04 -0800, Guenter Roeck wrote: >>> >>> Hi, >>> >>>> At least for my part I very much concentrated on making sure that >>>> the user space ABI as well as the port driver API are sane and usable. >>> >>> Rightly so, as this part cannot be changed once included in a kernel >>> release. >>> So, can we agree that that part at least is ready to go? >> >> I at least have no plans on doing any changes to the ABI. The API will >> change. > > I have received (off-list) some questions related to this. There are a > few things that people would like to still change after all. > > 1) Should we use "source" and "sink" instead of "device" and "host" > with the prefer_role attribute after all? I was uncomfortable with > that when we talked about it last time because the terms kept changing > with every new Type-C specification version. But I guess "source" and > "sink" would make sense in the end. This has been requested by several > guys now. > > 2) Can we change the way we list the supported roles? They are now > comma separated, but can we use new line instead: > > % cat supported_data_roles > host > device > % > > 3) Instead of the "supports_usb_power_delivery" attribute file which > we have for the ports and partners, it seem it would be more > interesting to know the supported USB Power Delivery Specification > version for some, and also USB Type-C Specification version in > separate attribute file. So basically we would have > "usb_power_delivery_version" and "usb_typec_version" attributes > instead or "supports_usb_power_delivery". > > > So would these changes be OK still at this point to everybody? > Ok with me. Guenter