From: Paolo Bonzini <pbonzini@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Roman Kagan <rkagan@virtuozzo.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kvm list <kvm@vger.kernel.org>, Minfei Huang <mnghuan@gmail.com>,
Andrew Lutomirski <luto@kernel.org>
Subject: Re: [PATCH] pvclock: introduce seqcount-like API
Date: Thu, 9 Jun 2016 20:03:02 +0200 [thread overview]
Message-ID: <3bfffd0d-bb91-d9e3-b67b-a82be9cb82d7@redhat.com> (raw)
In-Reply-To: <CALCETrWidbbfERQ0uEca8uOZvVzDWo-qF+0+NjwiF9A0R6Bthg@mail.gmail.com>
On 09/06/2016 19:12, Andy Lutomirski wrote:
> On Thu, Jun 9, 2016 at 6:45 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 09/06/2016 15:35, Roman Kagan wrote:
>>> On Thu, Jun 09, 2016 at 02:47:54PM +0200, Paolo Bonzini wrote:
>>>> On 09/06/2016 14:43, Roman Kagan wrote:
>>> Has it landed in any public tree? I'm unable to find any. There
>>> appears to be another version of the patch on the list, so I'm confused.
>>
>> I'm about to push it to kvm/master.
>
> Sorry for being slow. I'm catching up. In its current form, I don't
> like this patch. Please don't apply it.
Sure, I was talking about Minfei's patches, not this one. :) Of course
I need ack for this one.
> The problem is that this makes two significant changes at once:
>
> 1. Use the new version helpers. I like that change.
>
> 2. Use __pvclock_read_cycles. That should be separate, and it should
> come with timing numbers in the changelog.
__pvclock_read_cycles is pretty much the same as the code that is being
inlined. Thus the only change is that __pvclock_read_cycles is called
inside the loop rather than outside, but the loop really is expected to
never roll so why make a copy in the first place?
I'll split the patch anyway, thanks!
Paolo
next prev parent reply other threads:[~2016-06-09 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 11:23 [PATCH] pvclock: introduce seqcount-like API Paolo Bonzini
2016-06-09 12:43 ` Roman Kagan
2016-06-09 12:47 ` Paolo Bonzini
2016-06-09 13:35 ` Roman Kagan
2016-06-09 13:45 ` Paolo Bonzini
2016-06-09 17:12 ` Andy Lutomirski
2016-06-09 18:03 ` Paolo Bonzini [this message]
2016-06-09 18:08 ` Andy Lutomirski
2016-06-15 12:17 ` Paolo Bonzini
2016-06-12 10:25 ` Minfei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bfffd0d-bb91-d9e3-b67b-a82be9cb82d7@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mnghuan@gmail.com \
--cc=rkagan@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).