From: Waiman Long <longman@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] mm/memcg: Properly handle memcg_stock access for PREEMPT_RT
Date: Thu, 9 Dec 2021 21:47:16 -0500 [thread overview]
Message-ID: <3c06c8b3-c6ed-50c5-79ac-21982a10d417@redhat.com> (raw)
In-Reply-To: <20211210020632.150769-1-longman@redhat.com>
On 12/9/21 21:06, Waiman Long wrote:
> Direct calls to local_irq_{save/restore}() and preempt_{enable/disable}()
> are not appropriate for PREEMPT_RT. To provide better PREEMPT_RT support,
> change local_irq_{save/restore}() to local_lock_irq{save/restore}() and
> add a local_lock_t to struct memcg_stock_pcp.
>
> Also disable the task and interrupt context optimization for obj_stock as
> there will be no performance gain in the case of PREEMPT_RT. In this case,
> task obj_stock will be there but remain unused.
>
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
> mm/memcontrol.c | 41 ++++++++++++++++++++++-------------------
> 1 file changed, 22 insertions(+), 19 deletions(-)
Sorry, this doesn't apply to linux-next as it conflicts with a previous
patch that I sent out. Will send out a v2 soon.
-Longman
prev parent reply other threads:[~2021-12-10 2:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 2:06 [PATCH] mm/memcg: Properly handle memcg_stock access for PREEMPT_RT Waiman Long
2021-12-10 2:47 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c06c8b3-c6ed-50c5-79ac-21982a10d417@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=tglx@linutronix.de \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).