From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751601AbcLDK5S (ORCPT ); Sun, 4 Dec 2016 05:57:18 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:34154 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbcLDK5G (ORCPT ); Sun, 4 Dec 2016 05:57:06 -0500 Subject: Re: [PATCH 1/1] iio: light: fix improper return value To: Pan Bian , Kevin Tsai , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org References: <1480757057-3828-1-git-send-email-bianpan2016@163.com> Cc: linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <3c0b6176-65e8-0785-2259-5f2aac47d304@kernel.org> Date: Sun, 4 Dec 2016 10:57:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480757057-3828-1-git-send-email-bianpan2016@163.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/12/16 09:24, Pan Bian wrote: > In function cm3232_reg_init(), it returns 0 even if the last call to > i2c_smbus_write_byte_data() returns a negative value (indicates error). > As a result, the return value may be inconsistent with the execution > status, and the caller of cm3232_reg_init() will not be able to detect > the error. This patch fixes the bug. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188641 > > Signed-off-by: Pan Bian Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/light/cm3232.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/cm3232.c b/drivers/iio/light/cm3232.c > index fe89b68..263e972 100644 > --- a/drivers/iio/light/cm3232.c > +++ b/drivers/iio/light/cm3232.c > @@ -119,7 +119,7 @@ static int cm3232_reg_init(struct cm3232_chip *chip) > if (ret < 0) > dev_err(&chip->client->dev, "Error writing reg_cmd\n"); > > - return 0; > + return ret; > } > > /** >