From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] extcon: int3496: Ignore incorrect IoRestriction for ID pin
Date: Wed, 28 Feb 2018 16:01:14 +0100 [thread overview]
Message-ID: <3c1d4636-237c-2344-6c7c-fcd4468f48b9@redhat.com> (raw)
In-Reply-To: <20180226193444.69883-1-andriy.shevchenko@linux.intel.com>
Hi,
On 26-02-18 20:34, Andy Shevchenko wrote:
> The commit 70216fd937fe introduced a workaround for incorrect
> IoRestriction mode in ACPI table.
>
> Now, when GPIO ACPI library does it in generic way, just set
> an appropriate quirk flag instead.
>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Looks good to me and everything still works after this change,
so with the earlier review remarks fixed this is:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/extcon/extcon-intel-int3496.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
> index 191e99f06a9a..acaccb128fc4 100644
> --- a/drivers/extcon/extcon-intel-int3496.c
> +++ b/drivers/extcon/extcon-intel-int3496.c
> @@ -50,7 +50,11 @@ static const struct acpi_gpio_params vbus_gpios = { INT3496_GPIO_VBUS_EN, 0, fal
> static const struct acpi_gpio_params mux_gpios = { INT3496_GPIO_USB_MUX, 0, false };
>
> static const struct acpi_gpio_mapping acpi_int3496_default_gpios[] = {
> - { "id-gpios", &id_gpios, 1 },
> + /*
> + * Some platforms have a bug in ACPI GPIO description making IRQ
> + * GPIO to be output only. Ask the GPIO core to ignore this limit.
> + */
> + { "id-gpios", &id_gpios, 1, ACPI_GPIO_QUIRK_NO_IO_RESTRICTION },
> { "vbus-gpios", &vbus_gpios, 1 },
> { "mux-gpios", &mux_gpios, 1 },
> { },
> @@ -112,9 +116,6 @@ static int int3496_probe(struct platform_device *pdev)
> ret = PTR_ERR(data->gpio_usb_id);
> dev_err(dev, "can't request USB ID GPIO: %d\n", ret);
> return ret;
> - } else if (gpiod_get_direction(data->gpio_usb_id) != GPIOF_DIR_IN) {
> - dev_warn(dev, FW_BUG "USB ID GPIO not in input mode, fixing\n");
> - gpiod_direction_input(data->gpio_usb_id);
> }
>
> data->usb_id_irq = gpiod_to_irq(data->gpio_usb_id);
>
next prev parent reply other threads:[~2018-02-28 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180226193456epcas3p39565d818a6a57db386bd5e81aed20674@epcas3p3.samsung.com>
2018-02-26 19:34 ` [PATCH v1] extcon: int3496: Ignore incorrect IoRestriction for ID pin Andy Shevchenko
2018-02-27 3:59 ` Chanwoo Choi
2018-02-28 14:27 ` Andy Shevchenko
2018-02-28 14:28 ` Hans de Goede
2018-02-28 15:01 ` Hans de Goede [this message]
2018-02-28 16:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c1d4636-237c-2344-6c7c-fcd4468f48b9@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).