From: <Tudor.Ambarus@microchip.com>
To: <marek.vasut@gmail.com>, <dwmw2@infradead.org>,
<computersforpeace@gmail.com>, <boris.brezillon@bootlin.com>,
<richard@nod.at>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: fix selection of uniform erase type in flexible conf
Date: Fri, 16 Nov 2018 17:36:53 +0000 [thread overview]
Message-ID: <3c2c7a76-c7da-5c6e-0bb3-8963132f79d4@microchip.com> (raw)
In-Reply-To: <20181116111708.30259-1-tudor.ambarus@microchip.com>
On 11/16/2018 01:17 PM, Tudor Ambarus - M18064 wrote:
[cut]
> @@ -2729,9 +2751,8 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,
> * uniform_erase_type bitmask. The bitmask will be used later on when
> * selecting the uniform erase.
> */
> - spi_nor_regions_sort_erase_types(map);
> - map->uniform_erase_type = map->uniform_region.offset &
> - SNOR_ERASE_TYPE_MASK;
> + map->uniform_erase_type = spi_nor_sort_erase_mask(map,
> + map->uniform_erase_type);
Even if this particular change does not affect how erase works in uniform case,
it is not quite good because map->uniform_erase_type will not reflect what is in
map->uniform_region.offset & SNOR_ERASE_TYPE_MASK.
This change will be removed in v2.
Cheers,
ta
next prev parent reply other threads:[~2018-11-16 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 11:17 [PATCH] mtd: spi-nor: fix selection of uniform erase type in flexible conf Tudor.Ambarus
2018-11-16 17:36 ` Tudor.Ambarus [this message]
2018-11-16 17:46 ` [PATCH v2] " Tudor.Ambarus
2018-11-21 14:33 ` [v2] " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c2c7a76-c7da-5c6e-0bb3-8963132f79d4@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).