From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A8DC07E95 for ; Sun, 4 Jul 2021 13:58:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57FF8613C1 for ; Sun, 4 Jul 2021 13:58:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229549AbhGDOAw (ORCPT ); Sun, 4 Jul 2021 10:00:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbhGDOAt (ORCPT ); Sun, 4 Jul 2021 10:00:49 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B2F2C061762 for ; Sun, 4 Jul 2021 06:58:13 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id l1so9576495wme.4 for ; Sun, 04 Jul 2021 06:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=peVQlgAuI5gkYWsPGWsMpKMwMbGy8VbXwAvEnwV33sc=; b=pZCtNNLKX0dyXJx268hpQEX4T7tBZeH/yhIJwK39iZ9biqlAuBd3rXsN/piETw20hq 883k8IncemeG5P4DQ3/O1ha2spPpj5vsIIt2hxsnQpitKhPVPMEWAp1NAM8UKz7Fzf0W kTeYCxKWy9rbKNhvWy0jf0+Wr/B/TU9txw25dwRsSFFDGVxJFE5A0PiCsgfbnVqPFKau /761rZVFnQ/KsRke+/Vd23fbg+JZiWYu8feMkftielg+hmgTvi8rvjmtq8ZK4HVmlYBg YpkimxjJZBzBtYT/JLfB/QwE2d1PGjtE9tccnBgUrJANcBUwM3GMtKjouriPbAcIXytz jl0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=peVQlgAuI5gkYWsPGWsMpKMwMbGy8VbXwAvEnwV33sc=; b=T0xExRcVkQFpjT1jwQ26VxFve3HzbNq4T+BjTOPEnsoVArYePvMHFcJ0XDg4CYToX0 zYrZN5G4BZAA7Kp82NE+e1AIMD6Svnrw9iQQ1zj3opWFb/mBG92g97xjE/wx2MQP8yQk b74qghpRDMX2+lHoHdzkPJuJJa+sZJW5IQEh+YEKQhlKjX1n0U0hTdTZ/iLufXxQ+K5S elshm8kO9MUGo/Ue1UP/Y+0wSiOPTjQRrKamd3+fIGqrtOPEhyPFDnPCFcGv7OkU7I4j oTc6eRbeiJyDPsGXC8T68EmWIiGHYs4KQmCHIkIzWoYn3BNIvOPVONrO6jd87GnMzCfn QSoQ== X-Gm-Message-State: AOAM531w06JmfRZ6wCrJCkvB1dna8aGT5YosVAzDMyJVopk0+8jzXWGq f0WmzUQuNYRDv4ZEg1XAwZNpRw== X-Google-Smtp-Source: ABdhPJwnhV14VXeXgp+GI7enKPTisXpz3vnGi/SpdWSsm3jJJvKc7G0FswrrqpLsf1d+yltwy5cDSQ== X-Received: by 2002:a7b:ce98:: with SMTP id q24mr7411278wmj.101.1625407091623; Sun, 04 Jul 2021 06:58:11 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id t17sm9502969wrs.61.2021.07.04.06.58.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jul 2021 06:58:10 -0700 (PDT) Subject: Re: [V3] venus: helper: do not set constrained parameters for UBWC To: Mansur Alisha Shaik , bryan.odonoghue@linaro.org, linux-media@vger.kernel.org, stanimir.varbanov@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org, dikshita@codeaurora.org References: <1625202979-23232-1-git-send-email-mansur@codeaurora.org> From: Bryan O'Donoghue Message-ID: <3c3051aa-c897-266e-9648-ca6be933fda0@nexus-software.ie> Date: Sun, 4 Jul 2021 15:00:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1625202979-23232-1-git-send-email-mansur@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/07/2021 06:16, Mansur Alisha Shaik wrote: > plane constraints firmware interface is to override the default nitpick this should be "Plane constraints" > alignment for a given color format. By default venus hardware has > alignments as 128x32, but NV12 was defined differently to meet > various usecases. Compressed NV12 has always been aligned as 128x32, > hence not needed to override the default alignment. > > Fixes: bc28936bbba9 ("media: venus: helpers, hfi, vdec: Set actual plane constraints to FW") > Signed-off-by: Mansur Alisha Shaik > > Changes in V3: > - Elaborated commit message as per comments by Bryan > - As per Bryan comment alligned fixes in single line. > --- > drivers/media/platform/qcom/venus/helpers.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c > index 1fe6d46..601ee3e 100644 > --- a/drivers/media/platform/qcom/venus/helpers.c > +++ b/drivers/media/platform/qcom/venus/helpers.c > @@ -1137,8 +1137,12 @@ int venus_helper_set_format_constraints(struct venus_inst *inst) > if (!IS_V6(inst->core)) > return 0; > > + if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC) > + return 0; > + > pconstraint.buffer_type = HFI_BUFFER_OUTPUT2; > pconstraint.num_planes = 2; > + zap this newline, its not adding anything to your patch > pconstraint.plane_format[0].stride_multiples = 128; > pconstraint.plane_format[0].max_stride = 8192; > pconstraint.plane_format[0].min_plane_buffer_height_multiple = 32; > then please add my "Reviewed-by: Bryan O'Donoghue " --- bod