From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751634AbdAMMZ7 (ORCPT ); Fri, 13 Jan 2017 07:25:59 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:36259 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbdAMMZ5 (ORCPT ); Fri, 13 Jan 2017 07:25:57 -0500 Subject: Re: [PATCH v2 3/5] ARM: davinci_all_defconfig: enable iio and ADS7950 To: David Lechner References: <1483677228-2325-1-git-send-email-david@lechnology.com> <1483677228-2325-4-git-send-email-david@lechnology.com> <01ec2c94-46e0-3534-94e8-bd92f78b70ec@lechnology.com> CC: Mark Rutland , , Kevin Hilman , , Rob Herring , From: Sekhar Nori Message-ID: <3c4f8952-0a64-fc49-bd87-452dbbf7a946@ti.com> Date: Fri, 13 Jan 2017 17:54:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 11 January 2017 01:53 PM, Sekhar Nori wrote: > On Tuesday 10 January 2017 09:13 PM, David Lechner wrote: >> On 01/09/2017 06:29 AM, Sekhar Nori wrote: >>> On Friday 06 January 2017 10:03 AM, David Lechner wrote: >>>> This enables the iio subsystem and the TI ADS7950 driver. This is >>>> used by >>>> LEGO MINDSTORMS EV3, which has an ADS7957 chip. >>> >>> Can you add your sign-off? >>> >>>> --- >>>> >>>> The CONFIG_TI_ADS7950 driver is currently in iio/testing, so some >>>> coordination >>>> may be needed before picking up this patch. >>>> >>>> arch/arm/configs/davinci_all_defconfig | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/arch/arm/configs/davinci_all_defconfig >>>> b/arch/arm/configs/davinci_all_defconfig >>>> index 2b1967a..a899876 100644 >>>> --- a/arch/arm/configs/davinci_all_defconfig >>>> +++ b/arch/arm/configs/davinci_all_defconfig >>>> @@ -200,6 +200,13 @@ CONFIG_TI_EDMA=y >>>> CONFIG_MEMORY=y >>>> CONFIG_TI_AEMIF=m >>>> CONFIG_DA8XX_DDRCTL=y >>>> +CONFIG_IIO=m >>>> +CONFIG_IIO_BUFFER_CB=m >>>> +CONFIG_IIO_SW_DEVICE=m >>>> +CONFIG_IIO_SW_TRIGGER=m >>> >>>> +CONFIG_TI_ADS7950=m >>> >>> Can you separate this from rest of the patch. I would like to enable >>> this option only after I can find the symbol in linux-next. >> >> Will resend without CONFIG_TI_ADS7950 >> >>> >>>> +CONFIG_IIO_HRTIMER_TRIGGER=m >>>> +CONFIG_IIO_SYSFS_TRIGGER=m >>> >>> Need CONFIG_IIO_TRIGGER=y also for these two options to take effect. >> >> CONFIG_IIO_TRIGGER is selected by IIO_TRIGGERED_BUFFER [=m] && IIO [=m] >> && IIO_BUFFER [=y], so save_defconfig does not pick it up. > > I do remember I did not see these two modules did not get enabled in > .config after 'make davinci_all_defconfig'. Will check what I may have > missed. So IIO_TRIGGERED_BUFFER is not selected in my tree because I dont have the ADS7950 driver enabled. Same thing with IIO_BUFFER. Can you try this patch over my tree? Thanks, Sekhar