From: Randy Dunlap <rdunlap@infradead.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: modules_install: Warn if System.map file is not found
Date: Wed, 5 Sep 2018 09:15:54 -0700 [thread overview]
Message-ID: <3c595996-d6b2-1714-8b3b-3f21ab56263f@infradead.org> (raw)
In-Reply-To: <CAK7LNATshpTJ5sDH7pMzBbhd-zF7Yskv6ptiysn1X+pHB1Z8Dw@mail.gmail.com>
On 09/05/2018 12:17 AM, Masahiro Yamada wrote:
> Hi Randy,
>
> 2018-09-01 7:33 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> If there is no System.map file for "make modules_install",
>> scripts/depmod.sh will silently exit with success, having done
>> nothing. Since this is an unexpected situation, change it to
>> report a Warning for the missing file. The behavior is not
>> changed except for the Warning message.
>>
>> The (previous) silent success and new Warning can be reproduced
>> by:
>> $ make mrproper; make defconfig
>> $ make modules; make modules_install
>>
>> and since System.map is produced by "make vmlinux", the steps
>> above omit producing the System.map file.
>>
>> Reported-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> ---
>> scripts/depmod.sh | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- lnx-419-rc1.orig/scripts/depmod.sh
>> +++ lnx-419-rc1/scripts/depmod.sh
>> @@ -11,6 +11,7 @@ DEPMOD=$1
>> KERNELRELEASE=$2
>>
>> if ! test -r System.map ; then
>> + echo "Warning: modules_install: missing 'System.map' file"
>> exit 0
>> fi
>
> Thanks for the patch.
>
>
> For consistency, I'd like to suggest '>&2' for this warning too.
>
>
> Also, could you add a little more info
> about what happened (or what did not happen) then ?
>
>
>
> For example,
>
>
> Warning: modules_install: missing 'System.map' file. Skipping depmod.
Sure, will do.
thanks,
--
~Randy
prev parent reply other threads:[~2018-09-05 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 22:33 [PATCH] kbuild: modules_install: Warn if System.map file is not found Randy Dunlap
2018-09-05 7:17 ` Masahiro Yamada
2018-09-05 16:15 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c595996-d6b2-1714-8b3b-3f21ab56263f@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).