linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang
@ 2021-03-05  9:49 Gustavo A. R. Silva
  2021-03-05 12:19 ` Simon Horman
  0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05  9:49 UTC (permalink / raw)
  To: Simon Horman, Jakub Kicinski, David S. Miller
  Cc: oss-drivers, netdev, linux-kernel, Gustavo A. R. Silva, linux-hardening

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
index b3cabc274121..3b8e675087de 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
@@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
 	case NFP_PORT_PF_PORT:
 	case NFP_PORT_VF_PORT:
 		nfp_repr_vnic_get_stats64(repr->port, stats);
+		break;
 	default:
 		break;
 	}
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang
  2021-03-05  9:49 [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-03-05 12:19 ` Simon Horman
  2021-04-20 20:23   ` Gustavo A. R. Silva
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2021-03-05 12:19 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Jakub Kicinski, David S. Miller, oss-drivers, netdev,
	linux-kernel, linux-hardening

On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Thanks Gustavo,

this looks good to me.

Acked-by: Simon Horman <simon.horman@netronome.com>

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> index b3cabc274121..3b8e675087de 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
>  	case NFP_PORT_PF_PORT:
>  	case NFP_PORT_VF_PORT:
>  		nfp_repr_vnic_get_stats64(repr->port, stats);
> +		break;
>  	default:
>  		break;
>  	}
> -- 
> 2.27.0
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang
  2021-03-05 12:19 ` Simon Horman
@ 2021-04-20 20:23   ` Gustavo A. R. Silva
  2021-04-21  9:39     ` [oss-drivers] " Simon Horman
  0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 20:23 UTC (permalink / raw)
  To: Simon Horman, Gustavo A. R. Silva
  Cc: Jakub Kicinski, David S. Miller, oss-drivers, netdev,
	linux-kernel, linux-hardening

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 06:19, Simon Horman wrote:
> On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> 
> Thanks Gustavo,
> 
> this looks good to me.
> 
> Acked-by: Simon Horman <simon.horman@netronome.com>
> 
>> ---
>>  drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
>> index b3cabc274121..3b8e675087de 100644
>> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
>> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
>> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
>>  	case NFP_PORT_PF_PORT:
>>  	case NFP_PORT_VF_PORT:
>>  		nfp_repr_vnic_get_stats64(repr->port, stats);
>> +		break;
>>  	default:
>>  		break;
>>  	}
>> -- 
>> 2.27.0
>>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oss-drivers] Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang
  2021-04-20 20:23   ` Gustavo A. R. Silva
@ 2021-04-21  9:39     ` Simon Horman
  2021-05-18  0:07       ` Gustavo A. R. Silva
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2021-04-21  9:39 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Gustavo A. R. Silva, Jakub Kicinski, David S. Miller,
	oss-drivers, netdev, linux-kernel, linux-hardening

On Tue, Apr 20, 2021 at 03:23:39PM -0500, Gustavo A. R. Silva wrote:
> On 3/5/21 06:19, Simon Horman wrote:
> > On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote:
> >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> >> by explicitly adding a break statement instead of letting the code fall
> >> through to the next case.
> >>
> >> Link: https://github.com/KSPP/linux/issues/115
> >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > 
> > Thanks Gustavo,
> > 
> > this looks good to me.
> > 
> > Acked-by: Simon Horman <simon.horman@netronome.com>
>
> Hi all,
> 
> Friendly ping: who can take this, please?

Hi Jakub, Hi David,

I'm happy to repost this patch if it would help with your processes.

> >> ---
> >>  drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> >> index b3cabc274121..3b8e675087de 100644
> >> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> >> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> >> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
> >>  	case NFP_PORT_PF_PORT:
> >>  	case NFP_PORT_VF_PORT:
> >>  		nfp_repr_vnic_get_stats64(repr->port, stats);
> >> +		break;
> >>  	default:
> >>  		break;
> >>  	}
> >> -- 
> >> 2.27.0
> >>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [oss-drivers] Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang
  2021-04-21  9:39     ` [oss-drivers] " Simon Horman
@ 2021-05-18  0:07       ` Gustavo A. R. Silva
  0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-18  0:07 UTC (permalink / raw)
  To: Simon Horman
  Cc: Gustavo A. R. Silva, Jakub Kicinski, David S. Miller,
	oss-drivers, netdev, linux-kernel, linux-hardening

Hi all,

I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/21/21 04:39, Simon Horman wrote:
> On Tue, Apr 20, 2021 at 03:23:39PM -0500, Gustavo A. R. Silva wrote:
>> On 3/5/21 06:19, Simon Horman wrote:
>>> On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote:
>>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>>>> by explicitly adding a break statement instead of letting the code fall
>>>> through to the next case.
>>>>
>>>> Link: https://github.com/KSPP/linux/issues/115
>>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>>>
>>> Thanks Gustavo,
>>>
>>> this looks good to me.
>>>
>>> Acked-by: Simon Horman <simon.horman@netronome.com>
>>
>> Hi all,
>>
>> Friendly ping: who can take this, please?
> 
> Hi Jakub, Hi David,
> 
> I'm happy to repost this patch if it would help with your processes.
> 
>>>> ---
>>>>  drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
>>>> index b3cabc274121..3b8e675087de 100644
>>>> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
>>>> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
>>>> @@ -103,6 +103,7 @@ nfp_repr_get_stats64(struct net_device *netdev, struct rtnl_link_stats64 *stats)
>>>>  	case NFP_PORT_PF_PORT:
>>>>  	case NFP_PORT_VF_PORT:
>>>>  		nfp_repr_vnic_get_stats64(repr->port, stats);
>>>> +		break;
>>>>  	default:
>>>>  		break;
>>>>  	}
>>>> -- 
>>>> 2.27.0
>>>>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-05-18  0:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05  9:49 [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-05 12:19 ` Simon Horman
2021-04-20 20:23   ` Gustavo A. R. Silva
2021-04-21  9:39     ` [oss-drivers] " Simon Horman
2021-05-18  0:07       ` Gustavo A. R. Silva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).