* [PATCH] platform/x86: silead_dmi: Add touchscreen platform data for the Chuwi Surbook Mini tablet.
@ 2019-08-03 14:12 Giang Le
2019-08-03 14:16 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Giang Le @ 2019-08-03 14:12 UTC (permalink / raw)
To: hdegoede
Cc: dvhart, andy, linux-input, platform-driver-x86, linux-kernel, Giang Le
Signed-off-by: Giang Le <ohaibuzzle@gmail.com>
---
drivers/platform/x86/touchscreen_dmi.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 4370e4add83a..72535b0268eb 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -136,6 +136,22 @@ static const struct ts_dmi_data chuwi_vi10_data = {
.properties = chuwi_vi10_props,
};
+static const struct property_entry chuwi_surbook_mini_props[] = {
+ PROPERTY_ENTRY_U32("touchscreen-min-x", 88),
+ PROPERTY_ENTRY_U32("touchscreen-min-y", 13),
+ PROPERTY_ENTRY_U32("touchscreen-size-x", 2040),
+ PROPERTY_ENTRY_U32("touchscreen-size-y", 1524),
+ PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-surbook-mini.fw"),
+ PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+ PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+ { }
+};
+
+static const struct ts_dmi_data chuwi_surbook_mini_data = {
+ .acpi_name = "MSSL1680:00",
+ .properties = chuwi_surbook_mini_props,
+};
+
static const struct property_entry connect_tablet9_props[] = {
PROPERTY_ENTRY_U32("touchscreen-min-x", 9),
PROPERTY_ENTRY_U32("touchscreen-min-y", 10),
@@ -646,6 +662,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "S165"),
},
},
+ {
+ /* Chuwi Surbook Mini (CWI540) */
+ .driver_data = (void *)&chuwi_surbook_mini_data,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "C3W6_AP108_4G"),
+ },
+ },
{
/* Connect Tablet 9 */
.driver_data = (void *)&connect_tablet9_data,
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: silead_dmi: Add touchscreen platform data for the Chuwi Surbook Mini tablet.
2019-08-03 14:12 [PATCH] platform/x86: silead_dmi: Add touchscreen platform data for the Chuwi Surbook Mini tablet Giang Le
@ 2019-08-03 14:16 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2019-08-03 14:16 UTC (permalink / raw)
To: Giang Le; +Cc: dvhart, andy, linux-input, platform-driver-x86, linux-kernel
Hi,
On 03-08-19 16:12, Giang Le wrote:
Hmm, could have used a somewhat more verbose commit message above
the Signed-off-by line, but I guess there is not that much to write
about this patch.
> Signed-off-by: Giang Le <ohaibuzzle@gmail.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/touchscreen_dmi.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 4370e4add83a..72535b0268eb 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -136,6 +136,22 @@ static const struct ts_dmi_data chuwi_vi10_data = {
> .properties = chuwi_vi10_props,
> };
>
> +static const struct property_entry chuwi_surbook_mini_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-min-x", 88),
> + PROPERTY_ENTRY_U32("touchscreen-min-y", 13),
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 2040),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1524),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-surbook-mini.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + { }
> +};
> +
> +static const struct ts_dmi_data chuwi_surbook_mini_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = chuwi_surbook_mini_props,
> +};
> +
> static const struct property_entry connect_tablet9_props[] = {
> PROPERTY_ENTRY_U32("touchscreen-min-x", 9),
> PROPERTY_ENTRY_U32("touchscreen-min-y", 10),
> @@ -646,6 +662,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "S165"),
> },
> },
> + {
> + /* Chuwi Surbook Mini (CWI540) */
> + .driver_data = (void *)&chuwi_surbook_mini_data,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "C3W6_AP108_4G"),
> + },
> + },
> {
> /* Connect Tablet 9 */
> .driver_data = (void *)&connect_tablet9_data,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/x86: silead_dmi: Add touchscreen platform data for the Chuwi Surbook Mini tablet
2019-08-03 1:22 ohaibuzzle
@ 2019-08-03 9:17 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2019-08-03 9:17 UTC (permalink / raw)
To: ohaibuzzle; +Cc: dvhart, andy, linux-input, platform-driver-x86, linux-kernel
Hi "Buzzle",
To submit patches to the Linux kernel you need to use your real-name and
provide a Signed-off-by: line with your real name, see:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Regards,
Hans
On 03-08-19 03:22, ohaibuzzle@gmail.com wrote:
> From: Buzzle <ohaibuzzle@gmail.com>
>
> ---
> drivers/platform/x86/touchscreen_dmi.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 4370e4add83a..72535b0268eb 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -136,6 +136,22 @@ static const struct ts_dmi_data chuwi_vi10_data = {
> .properties = chuwi_vi10_props,
> };
>
> +static const struct property_entry chuwi_surbook_mini_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-min-x", 88),
> + PROPERTY_ENTRY_U32("touchscreen-min-y", 13),
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 2040),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1524),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-surbook-mini.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> + { }
> +};
> +
> +static const struct ts_dmi_data chuwi_surbook_mini_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = chuwi_surbook_mini_props,
> +};
> +
> static const struct property_entry connect_tablet9_props[] = {
> PROPERTY_ENTRY_U32("touchscreen-min-x", 9),
> PROPERTY_ENTRY_U32("touchscreen-min-y", 10),
> @@ -646,6 +662,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "S165"),
> },
> },
> + {
> + /* Chuwi Surbook Mini (CWI540) */
> + .driver_data = (void *)&chuwi_surbook_mini_data,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "C3W6_AP108_4G"),
> + },
> + },
> {
> /* Connect Tablet 9 */
> .driver_data = (void *)&connect_tablet9_data,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] platform/x86: silead_dmi: Add touchscreen platform data for the Chuwi Surbook Mini tablet
@ 2019-08-03 1:22 ohaibuzzle
2019-08-03 9:17 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: ohaibuzzle @ 2019-08-03 1:22 UTC (permalink / raw)
To: hdegoede
Cc: dvhart, andy, linux-input, platform-driver-x86, linux-kernel, Buzzle
From: Buzzle <ohaibuzzle@gmail.com>
---
drivers/platform/x86/touchscreen_dmi.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 4370e4add83a..72535b0268eb 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -136,6 +136,22 @@ static const struct ts_dmi_data chuwi_vi10_data = {
.properties = chuwi_vi10_props,
};
+static const struct property_entry chuwi_surbook_mini_props[] = {
+ PROPERTY_ENTRY_U32("touchscreen-min-x", 88),
+ PROPERTY_ENTRY_U32("touchscreen-min-y", 13),
+ PROPERTY_ENTRY_U32("touchscreen-size-x", 2040),
+ PROPERTY_ENTRY_U32("touchscreen-size-y", 1524),
+ PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-surbook-mini.fw"),
+ PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+ PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+ { }
+};
+
+static const struct ts_dmi_data chuwi_surbook_mini_data = {
+ .acpi_name = "MSSL1680:00",
+ .properties = chuwi_surbook_mini_props,
+};
+
static const struct property_entry connect_tablet9_props[] = {
PROPERTY_ENTRY_U32("touchscreen-min-x", 9),
PROPERTY_ENTRY_U32("touchscreen-min-y", 10),
@@ -646,6 +662,14 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "S165"),
},
},
+ {
+ /* Chuwi Surbook Mini (CWI540) */
+ .driver_data = (void *)&chuwi_surbook_mini_data,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "C3W6_AP108_4G"),
+ },
+ },
{
/* Connect Tablet 9 */
.driver_data = (void *)&connect_tablet9_data,
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-03 14:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-03 14:12 [PATCH] platform/x86: silead_dmi: Add touchscreen platform data for the Chuwi Surbook Mini tablet Giang Le
2019-08-03 14:16 ` Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2019-08-03 1:22 ohaibuzzle
2019-08-03 9:17 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).