From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: yassine.oudjana@gmail.com
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@kernel.org>,
Andy Teng <andy.teng@mediatek.com>,
Yassine Oudjana <y.oudjana@protonmail.com>,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: Combine MediaTek MT67xx pinctrl binding docs
Date: Wed, 21 Sep 2022 12:55:32 +0200 [thread overview]
Message-ID: <3cab86eb-2c5d-f6ec-a326-e34e63eabb24@collabora.com> (raw)
In-Reply-To: <H82KIR.LT5P242T2PJ72@gmail.com>
Il 21/09/22 12:24, yassine.oudjana@gmail.com ha scritto:
>
>
> On Wed, Sep 21 2022 at 11:45:41 AM +0200, AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>> Il 21/09/22 11:30, yassine.oudjana@gmail.com ha scritto:
>>>
>>>
>>> On Wed, Sep 21 2022 at 09:11:12 AM +0200, Krzysztof Kozlowski
>>> \x7f<krzysztof.kozlowski@linaro.org> wrote:
>>>> On 20/09/2022 10:06, AngeloGioacchino Del Regno wrote:
>>>>> Il 19/09/22 19:01, Yassine Oudjana ha scritto:
>>>>>> From: Yassine Oudjana <y.oudjana@protonmail.com>
>>>>>>
>>>>>> Documents for MT6779, MT6795 and MT6797 that currently exist share
>>>>>> most properties, and each one has slightly differently worded
>>>>>> descriptions for those properties. Combine all three documents into
>>>>>> one common document for all MT67xx SoC pin controllers, picking a few
>>>>>> parts from each and accounting for differences such as items in reg
>>>>>> and reg-names properties. Also document the MT6765 pin controller
>>>>>> which currently has a driver but no DT binding documentation. It should
>>>>>> be possible to also include bindings for MT8183 and MT8188, but these
>>>>>> have some additional properties that might complicate things a bit,
>>>>>> so they are left alone for now.
>>>>>>
>>>>>> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
>>>>>> ---
>>>>>> .../pinctrl/mediatek,mt6779-pinctrl.yaml | 207 ------------------
>>>>>> .../pinctrl/mediatek,mt6797-pinctrl.yaml | 176 ---------------
>>>>>> ...6795.yaml => mediatek,mt67xx-pinctrl.yaml} | 181 +++++++++++----
>>>>>
>>>>> Hello Yassine,
>>>>> nice cleanup over here!
>>>>>
>>>>> There's a catch though: as far as I know, wildcards are not permitted... so you
>>>>> should, at this point, merge all of these in mediatek,mt6779-pinctrl.yaml
>>>>> instead.
>>>>>
>>>>> Before jumping to that, though... Krzysztof, can you please confirm (or deny)?
>>>>
>>>> Wildcards are not allowed in compatibles. In filename wildcards or
>>>> family name could work if they are really going to match the devices. I
>>>> have doubts here. 67xx is quite a lot of different devices, so I am not
>>>> sure this will cover them all.
>>>>
>>>> I would prefer one name (oldest SoC or lowest number).
>>>
>>> Lowest number (and probably oldest too but not sure since mediatek naming
>>> \x7fconventions are a bit weird) currently documented is mt6779, but mt6765 gets
>>> \x7fdocumented in this patch and mt6735 (this one I know for sure is older than the
>>> \x7frest) in a following patch, so do I just stick with mt6779 or do I change it in
>>> the \x7ffollowing patches documenting mt6765 and mt6735?
>>>
>>
>> I see the sequence as:
>>
>> 1. You merge mediatek,mt6797-pinctrl.yaml into mediatek,mt6779-pinctrl.yaml; then
>
> And mediatek,pinctrl-mt6795 gets merged here too I assume?
>
Yeah sorry about forgetting that one. Anyway, obviously, do one merge operation
per commit!
>> 2. Adding MT6765 documentation to mediatek,mt6779-pinctrl.yaml; then
>> 3. Adding support for MT6735, documentation goes again to 6779-pinctrl.
>>
>> This means that you're working with mediatek,mt6779-pinctrl.yaml :-)
>>
>> P.S.: That was also a suggestion about how to split things per-commit!
>>
>> Cheers,
>> Angelo
>>
>>> Thanks,
>>> Yassine
>>>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>>
>>
>
>
next prev parent reply other threads:[~2022-09-21 10:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 17:01 [PATCH 0/4] MediaTek MT6735 pinctrl support and DT binding changes Yassine Oudjana
2022-09-19 17:01 ` [PATCH 1/4] dt-bindings: pinctrl: Combine MediaTek MT67xx pinctrl binding docs Yassine Oudjana
2022-09-20 8:06 ` AngeloGioacchino Del Regno
2022-09-21 7:11 ` Krzysztof Kozlowski
2022-09-21 9:30 ` yassine.oudjana
2022-09-21 9:45 ` AngeloGioacchino Del Regno
2022-09-21 10:24 ` yassine.oudjana
2022-09-21 10:55 ` AngeloGioacchino Del Regno [this message]
2022-09-21 7:20 ` Krzysztof Kozlowski
2022-09-21 9:25 ` yassine.oudjana
2022-09-19 17:01 ` [PATCH 2/4] arm64: dts: mediatek: mt6797: Make pin configuration nodes follow DT bindings Yassine Oudjana
2022-09-19 17:01 ` [PATCH 3/4] dt-bindings: pinctrl: mediatek,mt67xx-pinctrl: Document MT6735 pin controller bindings Yassine Oudjana
2022-09-19 17:01 ` [PATCH 4/4] pinctrl: mediatek: Add MT6735 pinctrl driver Yassine Oudjana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cab86eb-2c5d-f6ec-a326-e34e63eabb24@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=andy.teng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=y.oudjana@protonmail.com \
--cc=yassine.oudjana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).