From: Pavel Skripkin <paskripkin@gmail.com>
To: "Tetsuo Handa" <penguin-kernel@I-love.SAKURA.ne.jp>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
ath9k-devel@qca.qualcomm.com, kvalo@kernel.org,
davem@davemloft.net, kuba@kernel.org, linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+03110230a11411024147@syzkaller.appspotmail.com,
syzbot+c6dde1f690b60e0b9fbe@syzkaller.appspotmail.com
Subject: Re: [PATCH v3 1/2] ath9k: fix use-after-free in ath9k_hif_usb_rx_cb
Date: Thu, 5 May 2022 22:09:45 +0300 [thread overview]
Message-ID: <3cb712d9-c6be-94b7-6135-10b0eabba341@gmail.com> (raw)
In-Reply-To: <5fd22dda-01d6-cfae-3458-cb3fa23eb84d@I-love.SAKURA.ne.jp>
[-- Attachment #1.1: Type: text/plain, Size: 556 bytes --]
Hi Tetsuo,
On 5/2/22 09:10, Tetsuo Handa wrote:
>> And we can meet NULL defer even if we leave drv_priv = priv initialization
>> on it's place.
>
> I didn't catch the location. As long as "htc_handle->drv_priv = priv;" is done
> before complete_all(&hif_dev->fw_done) is done, is something wrong?
>
I don't really remember why I said that, but looks like I just haven't
opened callbacks' code.
My point was that my patch does not change the logic, but only fixes 2
problems: UAF and NULL deref.
With regards,
Pavel Skripkin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2022-05-05 19:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 20:24 [PATCH v3 1/2] ath9k: fix use-after-free in ath9k_hif_usb_rx_cb Pavel Skripkin
2022-02-07 20:24 ` [PATCH v3 2/2] ath9k: htc: clean up *STAT_* macros Pavel Skripkin
2022-02-07 21:24 ` Jeff Johnson
2022-02-08 15:32 ` Toke Høiland-Jørgensen
2022-02-08 15:49 ` Pavel Skripkin
2022-02-08 14:47 ` [PATCH v3 1/2] ath9k: fix use-after-free in ath9k_hif_usb_rx_cb Toke Høiland-Jørgensen
2022-02-08 15:48 ` Pavel Skripkin
2022-05-02 6:10 ` Tetsuo Handa
2022-05-05 19:09 ` Pavel Skripkin [this message]
2022-05-05 23:31 ` Tetsuo Handa
2022-05-10 19:26 ` Pavel Skripkin
2022-05-11 4:50 ` Kalle Valo
2022-05-11 9:53 ` Toke Høiland-Jørgensen
2022-05-11 9:59 ` Kalle Valo
2022-05-12 12:49 ` Toke Høiland-Jørgensen
2022-05-12 12:55 ` Pavel Skripkin
2022-05-12 13:48 ` Toke Høiland-Jørgensen
2022-05-12 16:05 ` Jeff Johnson
2022-05-12 16:09 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cb712d9-c6be-94b7-6135-10b0eabba341@gmail.com \
--to=paskripkin@gmail.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=syzbot+03110230a11411024147@syzkaller.appspotmail.com \
--cc=syzbot+c6dde1f690b60e0b9fbe@syzkaller.appspotmail.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).