From: Florian Fainelli <f.fainelli@gmail.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
linus.walleij@linaro.org, rjui@broadcom.com,
sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] pinctrl: bcm: nsp: implement get_direction
Date: Fri, 1 Nov 2019 19:55:48 -0700 [thread overview]
Message-ID: <3cc0fc66-c6da-45ba-c2d5-32877a180b57@gmail.com> (raw)
In-Reply-To: <20191101015621.12451-3-chris.packham@alliedtelesis.co.nz>
On 10/31/2019 6:56 PM, Chris Packham wrote:
> The get_direction api is strongly recommended to be implemented. In fact
> if it is not implemented gpio-hogs will not get the correct direction.
> Add an implementation of get_direction for the nsp-gpio driver.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
prev parent reply other threads:[~2019-11-02 2:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 1:56 [PATCH 0/2] pinctrl: bcm: nsp: gpio improvements Chris Packham
2019-11-01 1:56 ` [PATCH 1/2] pinctrl: bcm: nsp: use gpiolib infrastructure for interrupts Chris Packham
2019-11-02 2:55 ` Florian Fainelli
2019-11-03 21:17 ` Chris Packham
2019-11-03 22:23 ` Linus Walleij
2019-11-01 1:56 ` [PATCH 2/2] pinctrl: bcm: nsp: implement get_direction Chris Packham
2019-11-02 2:55 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cc0fc66-c6da-45ba-c2d5-32877a180b57@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).