From: Baokun Li <libaokun1@huawei.com>
To: Theodore Ts'o <tytso@mit.edu>, <linux-ext4@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <enwlinux@gmail.com>,
<jack@suse.cz>, <lczerner@redhat.com>, <yukuai3@huawei.com>,
<yi.zhang@huawei.com>, <yebin10@huawei.com>,
<ritesh.list@gmail.com>, <adilger.kernel@dilger.ca>
Subject: Re: [PATCH 0/2] ext4: fix a infinite loop in do_writepages after online resizing
Date: Wed, 30 Nov 2022 10:08:13 +0800 [thread overview]
Message-ID: <3cd4e5d1-4837-a569-18b4-72fcaabf103d@huawei.com> (raw)
In-Reply-To: <166975630697.2135297.7495422853696969304.b4-ty@mit.edu>
On 2022/11/30 5:12, Theodore Ts'o wrote:
> On Wed, 17 Aug 2022 21:26:59 +0800, Baokun Li wrote:
>> We got a issue: the ext4 writeback process was stuck in do_writepages and
>> do_writepages kept retrying. However, '-ENOMEM' is returned each time, even
>> if there is still free memory on the current machine.
>>
>> We find that the direct cause of this issue is that the bg_inode_table_hi
>> in the group descriptor is written to an incorrect value, which causes the
>> inode block found through the inode table to exceed the end_ block。Then,
>> sb_getblk always returns null, __ext4_get_inode_loc returns `-ENOMEM`,
>> and do_writepages keeps retrying.
>>
>> [...]
> Applied, thanks!
>
> [1/2] ext4: fix GDT corruption after online resizing with bigalloc enable and blocksize is 1024
> commit: 496fb12f8e236f303de6bc73a0334dd50c4eb64a
> [2/2] ext4: add inode table check in __ext4_get_inode_loc to aovid possible infinite loop
> commit: bfb0625e8e86f8797264b1c7d10e146afe243d23
>
> Best regards,
Hi Theodore,
Thank you very much for applying this patch set!
But I thought this patch set was discarded because there was no
"Reviewed-by".
And a few days ago, I came up with a better solution to the problem
fixed by PATCH 1/2.
The new solution is called "ext4: fix corruption when online resizing a
1K bigalloc fs", which
is in another patch set ("[PATCH v3 0/3] ext4: fix some bugs in online
resize") that fixes
some online resize problems. This patch set has been reviewed, and I
would appreciate it if
you could revert PATCH 1/2 and apply the patch set containing the new
solution.
Sorry for wasting your time without stating that a new solution is
available after the old patch.
Thanks again!
--
With Best Regards,
Baokun Li
next prev parent reply other threads:[~2022-11-30 2:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 13:26 [PATCH 0/2] ext4: fix a infinite loop in do_writepages after online resizing Baokun Li
2022-08-17 13:27 ` [PATCH 1/2] ext4: fix GDT corruption after online resizing with bigalloc enable and blocksize is 1024 Baokun Li
2022-08-17 13:27 ` [PATCH 2/2] ext4: add inode table check in __ext4_get_inode_loc to aovid possible infinite loop Baokun Li
2022-08-17 14:31 ` Jan Kara
2022-08-18 1:54 ` Baokun Li
2022-08-18 14:43 ` Ritesh Harjani (IBM)
2022-08-18 17:23 ` Jan Kara
2022-08-18 23:15 ` Ritesh Harjani (IBM)
2022-08-19 8:44 ` Jan Kara
2022-11-28 20:44 ` Theodore Ts'o
2022-11-29 8:54 ` Ritesh Harjani (IBM)
2022-11-29 21:12 ` [PATCH 0/2] ext4: fix a infinite loop in do_writepages after online resizing Theodore Ts'o
2022-11-30 2:08 ` Baokun Li [this message]
2022-12-01 3:42 ` Theodore Ts'o
2022-12-01 6:26 ` Baokun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cd4e5d1-4837-a569-18b4-72fcaabf103d@huawei.com \
--to=libaokun1@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=enwlinux@gmail.com \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=yebin10@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).