From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 07/11] arm64: dts: qcom: x1e80100: Add PCIe nodes
Date: Tue, 23 Jan 2024 19:20:38 +0100 [thread overview]
Message-ID: <3d029d7c-7efb-42bb-a16d-30cf965f410b@linaro.org> (raw)
In-Reply-To: <20240123-x1e80100-dts-missing-nodes-v4-7-072dc2f5c153@linaro.org>
On 1/23/24 12:01, Abel Vesa wrote:
> Add nodes for PCIe 4 and 6 controllers and their PHYs for X1E80100 platform.
>
> Co-developed-by: Sibi Sankar <quic_sibis@quicinc.com>
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> Co-developed-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
[...]
> +
> + interrupts = <GIC_SPI 773 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "msi";
You may want to add ITS MSIs too
[...]
> +
> + resets = <&gcc GCC_PCIE_6A_BCR>,
> + <&gcc GCC_PCIE_6A_LINK_DOWN_BCR>;
The second entry is misaligned
Konrad
next prev parent reply other threads:[~2024-01-23 18:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 11:01 [PATCH v4 00/11] arm64: dts: qcom: Add more support to X1E80100 base dtsi, CRD and QCP boards Abel Vesa
2024-01-23 11:01 ` [PATCH v4 01/11] arm64: dts: qcom: x1e80100: Add IPCC node Abel Vesa
2024-01-23 18:07 ` Konrad Dybcio
2024-01-23 11:01 ` [PATCH v4 02/11] arm64: dts: qcom: x1e80100: Add SMP2P nodes Abel Vesa
2024-01-23 18:30 ` Konrad Dybcio
2024-01-23 11:01 ` [PATCH v4 03/11] arm64: dts: qcom: x1e80100: Add QMP AOSS node Abel Vesa
2024-01-23 18:08 ` Konrad Dybcio
2024-01-23 11:01 ` [PATCH v4 04/11] arm64: dts: qcom: x1e80100: Add ADSP/CDSP remoteproc nodes Abel Vesa
2024-01-23 18:22 ` Konrad Dybcio
2024-01-24 12:37 ` Abel Vesa
2024-01-24 12:40 ` Konrad Dybcio
2024-01-23 11:01 ` [PATCH v4 05/11] arm64: dts: qcom: x1e80100: Add TCSR node Abel Vesa
2024-01-23 18:09 ` Konrad Dybcio
2024-01-26 8:18 ` Abel Vesa
2024-01-23 11:01 ` [PATCH v4 06/11] arm64: dts: qcom: x1e80100: Add USB nodes Abel Vesa
2024-01-23 18:17 ` Konrad Dybcio
2024-01-26 9:38 ` Abel Vesa
2024-01-23 11:01 ` [PATCH v4 07/11] arm64: dts: qcom: x1e80100: Add PCIe nodes Abel Vesa
2024-01-23 18:20 ` Konrad Dybcio [this message]
2024-01-25 8:02 ` Abel Vesa
2024-01-23 11:01 ` [PATCH v4 08/11] arm64: dts: qcom: x1e80100: Add display nodes Abel Vesa
2024-01-23 18:36 ` Konrad Dybcio
2024-01-25 8:01 ` Abel Vesa
2024-01-23 11:01 ` [PATCH v4 09/11] arm64: dts: qcom: x1e80100-crd: Enable more support Abel Vesa
2024-01-23 11:01 ` [PATCH v4 10/11] arm64: dts: qcom: x1e80100-qcp: " Abel Vesa
2024-01-23 11:01 ` [PATCH v4 11/11] arm64: dts: qcom: x1e80100-qcp: Fix supplies for LDOs 3E and 2J Abel Vesa
2024-01-23 18:21 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d029d7c-7efb-42bb-a16d-30cf965f410b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).