From: "Alex G." <mr.nuke.me@gmail.com>
To: linux-pci@vger.kernel.org, bhelgaas@google.com
Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com,
austin_bolen@dell.com, shyam_iyer@dell.com,
Frederick Lawler <fred@fredlawl.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oza Pawandeep <poza@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI/AER: Do not clear AER bits if we don't own AER
Date: Tue, 24 Jul 2018 10:59:32 -0500 [thread overview]
Message-ID: <3d05f662-2c29-90cd-9c74-6456939a0e6b@gmail.com> (raw)
In-Reply-To: <20180723165251.11424-1-mr.nuke.me@gmail.com>
On 07/23/2018 11:52 AM, Alexandru Gagniuc wrote:
> When we don't own AER, we shouldn't touch the AER error bits. Clearing
> error bits willy-nilly might cause firmware to miss some errors. In
> theory, these bits get cleared by FFS, or via ACPI _HPX method. These
> mechanisms are not subject to the problem.
>
> This race is mostly of theoretical significance, since I can't
> reasonably demonstrate this race in the lab.
>
> On a side-note, pcie_aer_is_kernel_first() is created to alleviate the
> need for two checks: aer_cap and get_firmware_first().
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> ---
> drivers/pci/pcie/aer.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index a2e88386af28..85c3e173c025 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -307,6 +307,12 @@ int pcie_aer_get_firmware_first(struct pci_dev *dev)
> aer_set_firmware_first(dev);
> return dev->__aer_firmware_first;
> }
> +
> +static bool pcie_aer_is_kernel_first(struct pci_dev *dev)
> +{
> + return !!dev->aer_cap && !pcie_aer_get_firmware_first(dev);
> +}
> +
> #define PCI_EXP_AER_FLAGS (PCI_EXP_DEVCTL_CERE | PCI_EXP_DEVCTL_NFERE | \
> PCI_EXP_DEVCTL_FERE | PCI_EXP_DEVCTL_URRE)
>
> @@ -337,10 +343,7 @@ bool aer_acpi_firmware_first(void)
>
> int pci_enable_pcie_error_reporting(struct pci_dev *dev)
> {
> - if (pcie_aer_get_firmware_first(dev))
> - return -EIO;
> -
> - if (!dev->aer_cap)
> + if (!pcie_aer_is_kernel_first(dev))
> return -EIO;
>
> return pcie_capability_set_word(dev, PCI_EXP_DEVCTL, PCI_EXP_AER_FLAGS);
> @@ -349,7 +352,7 @@ EXPORT_SYMBOL_GPL(pci_enable_pcie_error_reporting);
>
> int pci_disable_pcie_error_reporting(struct pci_dev *dev)
> {
> - if (pcie_aer_get_firmware_first(dev))
> + if (!pcie_aer_is_kernel_first(dev))
> return -EIO;
>
> return pcie_capability_clear_word(dev, PCI_EXP_DEVCTL,
> @@ -383,10 +386,10 @@ int pci_cleanup_aer_error_status_regs(struct pci_dev *dev)
> if (!pci_is_pcie(dev))
> return -ENODEV;
>
> - pos = dev->aer_cap;
> - if (!pos)
> + if (pcie_aer_is_kernel_first(dev))
This here is missing a '!'. It's in my local branch, so I must have
exported the patch before I fixed that. I'll get that fixed next rev.
> return -EIO;
>
> + pos = dev->aer_cap;
> port_type = pci_pcie_type(dev);
> if (port_type == PCI_EXP_TYPE_ROOT_PORT) {
> pci_read_config_dword(dev, pos + PCI_ERR_ROOT_STATUS, &status);
>
next prev parent reply other threads:[~2018-07-24 15:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 15:31 [PATCH] PCI/AER: Do not clear AER bits if we don't own AER Alexandru Gagniuc
2018-07-17 15:41 ` Sinan Kaya
2018-07-19 15:55 ` Alex G.
2018-07-19 16:58 ` Sinan Kaya
2018-07-19 19:56 ` Alex G.
2018-07-23 16:52 ` [PATCH v2] " Alexandru Gagniuc
2018-07-24 15:59 ` Alex G. [this message]
2018-07-30 23:35 ` [PATCH v3] " Alexandru Gagniuc
2018-08-08 1:14 ` Bjorn Helgaas
2018-08-08 3:46 ` Alex G.
2018-07-24 17:08 ` [PATCH v2] " kbuild test robot
2018-07-25 1:03 ` kbuild test robot
2018-08-09 14:15 ` [PATCH] " Bjorn Helgaas
2018-08-09 16:46 ` Alex_Gagniuc
2018-08-09 18:29 ` Bjorn Helgaas
2018-08-09 19:00 ` Alex G.
2018-08-09 19:18 ` Bjorn Helgaas
2018-08-09 19:42 ` Alex G.
2018-07-18 21:53 [PATCH v3] PCI: Check for PCIe downtraining conditions Bjorn Helgaas
2018-07-23 20:01 ` [PATCH v2] PCI/AER: Do not clear AER bits if we don't own AER Alexandru Gagniuc
2018-07-25 1:24 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d05f662-2c29-90cd-9c74-6456939a0e6b@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=alex_gagniuc@dellteam.com \
--cc=austin_bolen@dell.com \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=gregkh@linuxfoundation.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=poza@codeaurora.org \
--cc=shyam_iyer@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).