From: Lukasz Luba <lukasz.luba@arm.com>
To: Qiang Yu <yuq825@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
lima@lists.freedesktop.org,
dri-devel <dri-devel@lists.freedesktop.org>,
christianshewitt@gmail.com
Subject: Re: [PATCH] drm/lima: Use delayed timer as default in devfreq profile
Date: Mon, 1 Feb 2021 09:53:13 +0000 [thread overview]
Message-ID: <3d1b4696-0172-f88a-f41f-c66ac3baa429@arm.com> (raw)
In-Reply-To: <CAKGbVbsn=xVEa0=c3rywRShVZD18LkmLZ1qDUuDsrT5KnTjr6g@mail.gmail.com>
Hi Qiang,
On 1/30/21 1:51 PM, Qiang Yu wrote:
> Thanks for the patch. But I can't observe any difference on glmark2
> with or without this patch.
> Maybe you can provide other test which can benefit from it.
This is a design problem and has impact on the whole system.
There is a few issues. When the device is not checked and there are
long delays between last check and current, the history is broken.
It confuses the devfreq governor and thermal governor (Intelligent Power
Allocation (IPA)). Thermal governor works on stale stats data and makes
stupid decisions, because there is no new stats (device not checked).
Similar applies to devfreq simple_ondemand governor, where it 'tires' to
work on a loooong period even 3sec and make prediction for the next
frequency based on it (which is broken).
How it should be done: constant reliable check is needed, then:
- period is guaranteed and has fixed size, e.g 50ms or 100ms.
- device status is quite recent so thermal devfreq cooling provides
'fresh' data into thermal governor
This would prevent odd behavior and solve the broken cases.
>
> Considering it will wake up CPU more frequently, and user may choose
> to change this by sysfs,
> I'd like to not apply it.
The deferred timer for GPU is wrong option, for UFS or eMMC makes more
sense. It's also not recommended for NoC busses. I've discovered that
some time ago and proposed to have option to switch into delayed timer.
Trust me, it wasn't obvious to find out that this missing check has
those impacts. So the other engineers or users might not know that some
problems they faces (especially when the device load is changing) is due
to this delayed vs deffered timer and they will change it in the sysfs.
Regards,
Lukasz
>
> Regards,
> Qiang
>
next prev parent reply other threads:[~2021-02-01 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 10:51 [PATCH] drm/lima: Use delayed timer as default in devfreq profile Lukasz Luba
2021-01-30 13:51 ` Qiang Yu
2021-02-01 9:53 ` Lukasz Luba [this message]
2021-02-02 1:01 ` Qiang Yu
2021-02-02 14:02 ` Lukasz Luba
2021-02-03 2:01 ` Qiang Yu
2021-02-04 13:39 ` Robin Murphy
2021-02-04 14:23 ` Lukasz Luba
2021-02-07 13:11 ` Qiang Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d1b4696-0172-f88a-f41f-c66ac3baa429@arm.com \
--to=lukasz.luba@arm.com \
--cc=airlied@linux.ie \
--cc=christianshewitt@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=lima@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).