From: Heiner Kallweit <hkallweit1@gmail.com>
To: Wong Vee Khee <vee.khee.wong@linux.intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Voon Weifeng <weifeng.voon@intel.com>,
Ong Boon Leong <boon.leong.ong@intel.com>
Subject: Re: [PATCH net-next 1/2] net: phy: add genphy_c45_loopback
Date: Wed, 24 Mar 2021 12:02:22 +0100 [thread overview]
Message-ID: <3d344c5e-f1d9-67a6-9cd2-e7ee53cb413d@gmail.com> (raw)
In-Reply-To: <20210323164641.26059-2-vee.khee.wong@linux.intel.com>
On 23.03.2021 17:46, Wong Vee Khee wrote:
> Add generic code to enable C45 PHY loopback into the common phy-c45.c
> file. This will allow C45 PHY drivers aceess this by setting
> .set_loopback.
>
> Suggested-by: Heiner Kallweit <hkallweit1@gmail.com>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
> ---
> drivers/net/phy/phy-c45.c | 8 ++++++++
> include/linux/phy.h | 1 +
> 2 files changed, 9 insertions(+)
>
LGTM
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
next prev parent reply other threads:[~2021-03-24 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 16:46 [PATCH net-next 0/2] Add support for Clause-45 PHY Loopback Wong Vee Khee
2021-03-23 16:46 ` [PATCH net-next 1/2] net: phy: add genphy_c45_loopback Wong Vee Khee
2021-03-24 11:02 ` Heiner Kallweit [this message]
2021-03-24 22:04 ` Andrew Lunn
2021-03-23 16:46 ` [PATCH net-next 2/2] net: phy: marvell10g: Add PHY loopback support Wong Vee Khee
2021-03-24 22:04 ` Andrew Lunn
2021-03-24 23:30 ` [PATCH net-next 0/2] Add support for Clause-45 PHY Loopback patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d344c5e-f1d9-67a6-9cd2-e7ee53cb413d@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vee.khee.wong@linux.intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).