From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] staging: r8188eu: some cleanups
Date: Sun, 2 Oct 2022 10:59:15 +0200 [thread overview]
Message-ID: <3d4a383b-8029-90e3-867b-c91a19345263@gmail.com> (raw)
In-Reply-To: <20221002074827.8566-1-straube.linux@gmail.com>
On 10/2/22 09:48, Michael Straube wrote:
> The first patch of this series merges leftover macros in odm_types.h
> into appropriate other headers and removes odm_types.h.
>
> The other patches convert some functions away from returning _FAIL /
> _SUCCESS.
>
> Note: Converting _rtw_init_xmit_priv() and _rtw_init_recv_priv() away
> from _FAIL / _SUCCESS is a bit more complicated. I am going to do that
> in follow up patches.
>
> Tested on x86_64 with Inter-Tech DMG-02.
>
> Michael Straube (5):
> staging: r8188eu: merge odm_types.h into other headers
> staging: r8188eu: convert rtw_init_evt_priv() to common error logic
> staging: r8188eu: convert rtw_init_cmd_priv() to common error logic
> staging: r8188eu: convert rtw_init_mlme_priv() to common error logic
> staging: r8188eu: convert _rtw_init_sta_priv() to common error logic
>
> drivers/staging/r8188eu/core/rtw_cmd.c | 16 +++++++---------
> drivers/staging/r8188eu/core/rtw_mlme.c | 12 ++++--------
> drivers/staging/r8188eu/core/rtw_sta_mgt.c | 6 +++---
> drivers/staging/r8188eu/include/odm.h | 3 ++-
> drivers/staging/r8188eu/include/odm_RTL8188E.h | 7 +++++++
> drivers/staging/r8188eu/include/odm_types.h | 16 ----------------
> drivers/staging/r8188eu/include/rtl8188e_hal.h | 1 -
> drivers/staging/r8188eu/include/rtw_cmd.h | 4 ++--
> drivers/staging/r8188eu/include/sta_info.h | 2 +-
> drivers/staging/r8188eu/os_dep/os_intfs.c | 8 ++++----
> 10 files changed, 30 insertions(+), 45 deletions(-)
> delete mode 100644 drivers/staging/r8188eu/include/odm_types.h
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
prev parent reply other threads:[~2022-10-02 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 7:48 [PATCH 0/5] staging: r8188eu: some cleanups Michael Straube
2022-10-02 7:48 ` [PATCH 1/5] staging: r8188eu: merge odm_types.h into other headers Michael Straube
2022-10-02 7:48 ` [PATCH 2/5] staging: r8188eu: convert rtw_init_evt_priv() to common error logic Michael Straube
2022-10-02 7:48 ` [PATCH 3/5] staging: r8188eu: convert rtw_init_cmd_priv() " Michael Straube
2022-10-02 7:48 ` [PATCH 4/5] staging: r8188eu: convert rtw_init_mlme_priv() " Michael Straube
2022-10-02 7:48 ` [PATCH 5/5] staging: r8188eu: convert _rtw_init_sta_priv() " Michael Straube
2022-10-02 8:59 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d4a383b-8029-90e3-867b-c91a19345263@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).