From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755505AbdDRNei (ORCPT ); Tue, 18 Apr 2017 09:34:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48082 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbdDRNef (ORCPT ); Tue, 18 Apr 2017 09:34:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1449264E5 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pbonzini@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1449264E5 Subject: Re: [PATCH V4] x86: call smp vmxoff in smp stop To: Xishi Qiu , Ingo Molnar , "H. Peter Anvin" References: <586CCA5A.8050607@huawei.com> <586DA529.1040803@huawei.com> <58798201.2@huawei.com> <587F523B.80301@huawei.com> Cc: Thomas Gleixner , the arch/x86 maintainers , wanpeng.li@hotmail.com, Andrew Morton , hidehiro.kawai.ez@hitachi.com, LKML , Fengtiantian , Xiexiuqi From: Paolo Bonzini Message-ID: <3d5bf4c2-7415-a976-62fb-ba653f92eada@redhat.com> Date: Tue, 18 Apr 2017 15:34:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <587F523B.80301@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 18 Apr 2017 13:34:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo, can you put this in tip? Thanks, Paolo On 18/01/2017 12:32, Xishi Qiu wrote: > From: Tiantian Feng > > We need to disable VMX on all CPUs before stop cpu when OS panic, > otherwisewe risk hanging up the machine, because the CPU ignore INIT > signals when VMX is enabled. In kernel mainline this issue existence. > > Signed-off-by: Tiantian Feng > Signed-off-by: Xishi Qiu > --- > arch/x86/kernel/smp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c > index 68f8cc2..b574d55 100644 > --- a/arch/x86/kernel/smp.c > +++ b/arch/x86/kernel/smp.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > > /* > * Some notes on x86 processor bugs affecting SMP operation: > @@ -162,6 +163,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs) > if (raw_smp_processor_id() == atomic_read(&stopping_cpu)) > return NMI_HANDLED; > > + cpu_emergency_vmxoff(); > stop_this_cpu(NULL); > > return NMI_HANDLED; > @@ -174,6 +176,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs) > asmlinkage __visible void smp_reboot_interrupt(void) > { > ipi_entering_ack_irq(); > + cpu_emergency_vmxoff(); > stop_this_cpu(NULL); > irq_exit(); > } >