From: Jon Hunter <jonathanh@nvidia.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Qian Cai <qcai@redhat.com>, <carver4lio@163.com>,
<rppt@kernel.org>
Cc: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Hailong Liu <liu.hailong6@zte.com.cn>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] mm/memblock:use a more appropriate order calculation when free memblock pages
Date: Fri, 4 Dec 2020 17:43:21 +0000 [thread overview]
Message-ID: <3d709122-0364-5bca-9247-3f212096b389@nvidia.com> (raw)
In-Reply-To: <adc36428-05eb-f885-9394-080cc805818f@samsung.com>
On 04/12/2020 16:07, Marek Szyprowski wrote:
> Hi All,
>
> On 04.12.2020 14:42, Qian Cai wrote:
>> On Thu, 2020-12-03 at 23:23 +0800, carver4lio@163.com wrote:
>>> From: Hailong Liu <liu.hailong6@zte.com.cn>
>>>
>>> When system in the booting stage, pages span from [start, end] of a memblock
>>> are freed to buddy in a order as large as possible (less than MAX_ORDER) at
>>> first, then decrease gradually to a proper order(less than end) in a loop.
>>>
>>> However, *min(MAX_ORDER - 1UL, __ffs(start))* can not get the largest order
>>> in some cases.
>>> Instead, *__ffs(end - start)* may be more appropriate and meaningful.
>>>
>>> Signed-off-by: Hailong Liu <liu.hailong6@zte.com.cn>
>> Reverting this commit on the top of today's linux-next fixed boot crashes on
>> multiple NUMA systems.
>
> I confirm. Reverting commit 4df001639c84 ("mm/memblock: use a more
> appropriate order calculation when free memblock pages") on top of linux
> next-20201204 fixed booting of my ARM32bit test systems.
FWIW, I also confirm that this is causing several 32-bit Tegra platforms
to crash on boot and reverting this fixes the problem.
Jon
--
nvpublic
next prev parent reply other threads:[~2020-12-04 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 15:23 [PATCH] mm/memblock:use a more appropriate order calculation when free memblock pages carver4lio
2020-12-04 13:42 ` Qian Cai
[not found] ` <CGME20201204160751eucas1p13cc7aad8c68dd2a495c4bbf422c4228c@eucas1p1.samsung.com>
2020-12-04 16:07 ` Marek Szyprowski
2020-12-04 17:43 ` Jon Hunter [this message]
2020-12-05 17:09 ` Anders Roxell
2020-12-05 17:12 ` Anders Roxell
2020-12-06 11:55 ` Mike Rapoport
2020-12-06 14:21 ` carver4lio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d709122-0364-5bca-9247-3f212096b389@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=carver4lio@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=liu.hailong6@zte.com.cn \
--cc=m.szyprowski@samsung.com \
--cc=qcai@redhat.com \
--cc=rppt@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).