From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935890AbcKDP3r (ORCPT ); Fri, 4 Nov 2016 11:29:47 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:41369 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935651AbcKDP3p (ORCPT ); Fri, 4 Nov 2016 11:29:45 -0400 Subject: Re: [PATCH V2 2/2] blk-mq: immediately dispatch big size request To: Christoph Hellwig References: <05e8cb8c7e09903c7db36e81a6bbd0b39b24deff.1478217670.git.shli@fb.com> <6297c9a39cf21c94c65d5a9b3a19e54ba5b8b573.1478217671.git.shli@fb.com> <20161104000954.GA10266@infradead.org> <20161104001353.GA58908@omida-mbp.local.dhcp.thefacebook.com> <32bef0f6-c194-e31e-3a85-5aa21a6e81a4@fb.com> <20161104144614.GA18373@infradead.org> CC: Shaohua Li , , , From: Jens Axboe Message-ID: <3d7144e3-47e5-3c98-489f-e92d97b60817@fb.com> Date: Fri, 4 Nov 2016 09:29:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161104144614.GA18373@infradead.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [166.176.59.136] X-ClientProxiedBy: BN6PR1601CA0016.namprd16.prod.outlook.com (10.172.104.154) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: d48ef8d9-f9e3-47d6-2f03-08d404c75706 X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;2:/Vk4gZP49Z4IlVS+b681RKkRVRW+lNwNEn6QBlwKPjBenVicqYlCXxuON4NiNSlgiRJKG+yrudhG249gExG+44uSY9ob153SsjYfM4qGILdtOOYk8P7kuxilgBlyzkJ+wJyJTM06+mIz3PQXwRY1li+oYC4czjURmFeVFqq8ULx92nlboQo2p87ygxdcaZ6drxpNWOhTt64rMdd6px6BCw==;3:vlH+GA8ia+18YvQyth/QO2Vw0LRc6+8QXZog+30DdXCxCo0GY66glT+EB4xr+hahxgwpqULr2cbhRy5ynBVhaAxDK+Vka0/OgpptXNXHnNmlFhbySOfNEq7n/tAN/2k0HEAWPLlOyxMymDPDa6FdyQ==;25:GsKC+oRx9xG5Y+SiD4w1SVr8GZGvddEbB4FbQoqZJVNlvrzY2WvOJp6as+/sn/aQleJR7NHpEOB0xhUwsjGe1eRU4qF2uo8Ltene5zxCgBKN+gzQnE8jPVoFZRhBU4cnuJzHkeqB2ayHPd7NAVVnkAyk9OxL+LIt6ZU7qaUPtsIi2dAl8PZQABdB7X/zZFHK+KM494kADQ+qo/RFAo1LMey4NxSovPL7zlwECvgi6bFBAbKrokCK9jnYcdaUTJwNW16BxCXdbmtqyOKZhEQVbRxMyp3ZeZoHiS9PL367QRgdqY3SZdJNHQzNXHw42KyGDcTrsEuWXeYJtlAlapAHQdKaMeX4WXlws0UY/dyaU2sxT+87hlWtGJ0MP4Ai2a+T1vPqTdlbeaucOgARbcwkpkbNVWqwMo5zmaNman1/gNIUFiK+ovwScd5qiGvT+z40 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;31:NWFQ2sULA8Wu2gQRBEv318DWf+rFICBfNjVRs1zUFI5ad6y55i9RFa2s8/Rb8GJn2OXn0ty53tSbICAt52bS5KXfiifGLfombZ5918fB2bOg/RprMvOzZ3pmpYYIKaaizpCyFJeHTN2YlJk1A2d0yvaTFLpWc/PVArwV3kVDGPmeAugVM4bKy0HBlLUjpymhRKqV9HS0byFr/YGQ5YKW33MRvziazf4SnO7RKOwH85C2zRqDOW9gmvZaA5Yj8AJ7;20:QnY0SuPzUMv5tZwOvX1JnRnnwI7ywgrDYLYD0rMueVX+1UZqKDO+pidX/POziSMR7JQ14r4nW8jkx0Q41vmcHGgKHb2JsCZLz9EUNg8/MJJnU9OXlHkZ4d3+R6xopLzPhWKhkpIo2EftfjvmGwvc5C9QDD2HySSipzny+2n9Y+I=;4:DCU5gWSzaDTGcc8sB43ecQ4AR2rVLSgojT2pfnvoTtfLiMyiXLFxKmNgOgADUzYM//uzC1SX1Y5H7PRtNWHd/fHHj+pebKIiYfxP3G16aT73QHR05QYj0A3BLef1OxbH4kgdj+btnsATEDaQHNF66jwwo5YjnQfGDZ7dJlZrifEuejqKRn17r710hpYntiuZHe2EgT2ircq+0kdq0SRe9A3UaO79/74N97Vhs6I7KKjZtk6yJ6HRC1L01B0ZIb4+zzolMPmpSuZnOOxfoSq58qRdjdvHlg/OP/MGybYH47uXZpdZNhsaoi9wi/zUamvQ5yzcdTofjXZ5M7m5pIv3nPFrKpK7rYrlNhN9ziCALRQFR9jf3mOpQINshpzBv95zAA1HL+8mqE+4p3Ow4o4KTA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY4PR15MB1192;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Forefront-PRVS: 01165471DB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(51444003)(52314003)(377454003)(24454002)(199003)(189002)(36756003)(6666003)(7736002)(7846002)(101416001)(305945005)(76176999)(54356999)(50986999)(110136003)(68736007)(93886004)(77096005)(65826007)(2950100002)(6916009)(92566002)(23746002)(33646002)(5660300001)(97736004)(189998001)(4001350100001)(86362001)(31696002)(50466002)(64126003)(106356001)(81156014)(83506001)(105586002)(8676002)(3846002)(6116002)(65956001)(81166006)(4326007)(586003)(47776003)(2906002)(65806001)(66066001)(42186005)(230700001)(31686004)(14773001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1192;H:[172.20.10.9];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1192;23:wmhj5W0YJ3owYnq5JSN0BV7dWIpMEmBEeyJ/A?= =?Windows-1252?Q?39YMqZHlN0k6PQm/CU6JYjOBl9Uf7dP/LnLmYUpNT0UGAkWfBfalmPaO?= =?Windows-1252?Q?n5BONr2nJz9Wzx5GNTDK1/vn8w/TxOUjFOSuV+BchharSJEl3tpenwqL?= =?Windows-1252?Q?4+pLfUfk4BRp0A8QBslHpFF/pbt0poJ+ATE/N3lVUumbSODy7vZ8Knv2?= =?Windows-1252?Q?vRkEDpQpBnvqOC9J05JnGotZvdFPMtmMDM7nEGoMbaqw6UDc/Mi3Q5+K?= =?Windows-1252?Q?yPU1ss6ijjI2s217RLZP8PIq+ZBTB+w+d2LS5bohP3XQJVvOVIKCzGZc?= =?Windows-1252?Q?UDPcoJGbqoJc6axT9JN5cnBMGXzdib+PZYTFTpTQcNSqIA5Unv7eSAnF?= =?Windows-1252?Q?IRDd1/lQyxX/tArC3vy3IUoDb80kpKX6YjgS22XVCQP5BoGCJII4uzQm?= =?Windows-1252?Q?pYPyiyNEmXd31y+bIcVrpGrQtp39K+D3Wmt+7A/S4p3KOw9uadq+MRL8?= =?Windows-1252?Q?+7LqDElcN0XHWwWtlaNd77W0z9VtTkJilDDEiP6jE14FCUOq9JEnby3+?= =?Windows-1252?Q?fg31+4Xztbty50yiwGeJVXE/Zul3CkyN8Vvv7KsnTHH782pKNHeFHW24?= =?Windows-1252?Q?jzdQqvZfJnLq+9lcgak5npcTeUvtMll5dzpim7lL4vpSqB66ukaMMhRH?= =?Windows-1252?Q?b7XcEjz9moXoUFGY20G1azTwwl+Rl3HIOQAQzc8sx6SlFWSv2xk1P82/?= =?Windows-1252?Q?kTvqFlOYtg2k/bSvwiejVMTTf56ikVPAe5oSPV4lHVn7iWoZK9SDP9LU?= =?Windows-1252?Q?QbB37R7mhvL9ON26DnNECCvvx+Js7VL7s7uZgdPp2KA3T0Z28y1xFQnw?= =?Windows-1252?Q?qP72sFsE3H+BCZWk0gBEfy64gtzOsfEa9Fc27BH4PNHvr9djw0JtmC+d?= =?Windows-1252?Q?AyCSv7dawWoSu3ZXEMZmZnusCxvk/mVj76eC/Y16Xc5sEIzxsn/tVBkl?= =?Windows-1252?Q?+iVTb/uBDwGCz9cCXFrBX9jVUPaD5WeNaoJiOPUfuaUuflUKlpJXLdlM?= =?Windows-1252?Q?77rqltGBNoWH8QLoeamFLRzlgV42MlYj6eJzbSgOJKO0B6AFKkpHFsRj?= =?Windows-1252?Q?FKPIGSOL8p8XEPw2R3GhWyHOuaroF4QxFFSDWOP8PT8uFTw+F5ZGTjOu?= =?Windows-1252?Q?CmZ9H6SuX368Oy6ihsIopMsdzD71iHUsmROnZ6UnJXXCJ1w5UuWzh4nX?= =?Windows-1252?Q?kIvODJvBLd2l+Tf7wtFYzw7DadHrSnwOmWc7N7tU9+kSsKX3yGAj3wJi?= =?Windows-1252?Q?83ySaySf7H3YWqv04l2Sv4318V2NjcQ0TSsEZPQ1M+TKxqU5Ccs+0kw5?= =?Windows-1252?Q?llx7P0ijJypFzHg1hV+/0FE+PpDHK3iq/a96wiUM8LWpBO1Ixp+DLfYC?= =?Windows-1252?Q?RI6QEwXmJTcbUsE+ZVvr47+N0Lqq4W9SlmzUUJLUA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;6:EhiI/mM2Vdql2SJsku2v2wLAhpZjJwGwFpJEXRx3rPb8C/MahRJGbn6yBzOTgzmQrNEk9LORbXex1WFVKU0vzEFsS69Bi0pyPSXlzRpTD8p7R97AQsFMF7FY8M5vLY6QO9osg96xMqx12APM5o1tTndbWuD2QtnQs8OKAni2vipUe963xK/hyRm/NgIkyWs6fUviX70lV0Rk4US0gkjjPj/3PR72Y+mYil6/0VagDJUL2/uSkcPf5ZSntRReioOS7aUfsj5jLtn8tHaWs4Fr+tSi2dbDZa+F/ju4r3Nca0jpQNBUNm3xHWeZMrvYAzGu;5:sdC36BVo6+BO9y3hGpJ/Kmz7FRhqMY7yoYKWxAG3/dC6xXjLbvjKf9KPvHgp8hF6d7p9EYBl8j0OL0Kt7f8yb5b0497LNHV4LGg7W6Mu/Jst83x4DgBzdz5/uPUndXDee3jveypTG9DsDIpFNf5zIg==;24:fyNzdSFBRX5e6IK8e0WybStjdD2Ga7gcfUYZAxT3vZH4pwaPHyZg1ISgCx/C1GzYJocSVCjyAPOysbaVZj59Be/niF5URymLsSrJL92TX2Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;7:ze0cGmaI68BRqLZKXW2O9cYiYn4j6v8yjpRAxR4CjZIBDfmbI4QdU37Myet4mP3uw6/X+KEOugDaiShqTUHCc7sO7ZWNvcxTqWUySOmsU/Ddifxj8zh7vThExZ+lNSc4VlskEOS5+1HPgQewS6014DlUNZ2R9c/1BC3PtWhhZTns0u+2fKJZm7HJikCwT8yKqCMOv+/UDfqiPjhLtbAUsNSeNfVUIiV6cJGWZLZvGJHAipOBeqPv1wFrnttZiT3tEqYAZ/TMT/poH47PNx2/Ysa/QtJAu9gSvo+MAHLHAlNmDywQaiRsPqdRgV/sS0CKEWdvvqpNngVwcVGi/b3OU2HYvZCX+XO1awZpLZzgN/Y=;20:NgQmV1mYzL8ANgfHTJ7W0eq6FEzTMIjWYhfp4dSqCSj7kXsfCKoSphBZmMeENhvlon/jPFWfrck+N7STH01vJ8UpQ8Uk1jyXYxAVcw0bnicswEem1T02QuWijXBviuyFhm3KfON2KvakLWyUkHPZCyRtJo02d3yrEqTiqcEbrlk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2016 15:29:15.1472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-04_03:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2016 08:46 AM, Christoph Hellwig wrote: > On Thu, Nov 03, 2016 at 10:00:58PM -0600, Jens Axboe wrote: >> I've applied 1-2 for 4.10, but we probably should look into unifying >> those parts of sq and mq in general. For instance, it doesn't seem to >> make a lot of sense why we'd depth limit sq and not mq. > > I've spent some time looking the the make_request_fn and to be honest > I think that whole sq vs mq split is pointless. They are about 70-80% > the same anyway, and I think everyone would be served much better > by merging them. Yeah, that was my point, at least if we can do it without having too many extra conditionals. Or at least split some of it into helpers. -- Jens Axboe