From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, pavel@ucw.cz
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 13/18] leds: lp55xx: Add multicolor framework support to lp55xx
Date: Wed, 16 Oct 2019 22:44:21 +0200 [thread overview]
Message-ID: <3d73452f-fd41-0b63-c79d-c29ed70867af@gmail.com> (raw)
In-Reply-To: <20191016155954.29044-14-dmurphy@ti.com>
Dan,
Some variable naming related nitpicking below.
On 10/16/19 5:59 PM, Dan Murphy wrote:
> Add multicolor framework support for the lp55xx family.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/leds/Kconfig | 2 +
> drivers/leds/leds-lp55xx-common.c | 175 +++++++++++++++++++---
> drivers/leds/leds-lp55xx-common.h | 9 ++
> include/linux/platform_data/leds-lp55xx.h | 7 +
> 4 files changed, 170 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index fb614a6b9afa..a121a2855c06 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -377,8 +377,10 @@ config LEDS_LP50XX
> config LEDS_LP55XX_COMMON
> tristate "Common Driver for TI/National LP5521/5523/55231/5562/8501"
> depends on LEDS_LP5521 || LEDS_LP5523 || LEDS_LP5562 || LEDS_LP8501
> + depends on OF
> select FW_LOADER
> select FW_LOADER_USER_HELPER
> + select LEDS_CLASS_MULTI_COLOR
> help
> This option supports common operations for LP5521/5523/55231/5562/8501
> devices.
> diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c
> index 824d1d73dde1..026ebc2f8e18 100644
> --- a/drivers/leds/leds-lp55xx-common.c
> +++ b/drivers/leds/leds-lp55xx-common.c
> @@ -131,14 +131,54 @@ static struct attribute *lp55xx_led_attrs[] = {
> };
> ATTRIBUTE_GROUPS(lp55xx_led);
>
> +static int lp55xx_map_channel(struct lp55xx_led *led, int color_id,
> + enum led_brightness brightness)
> +{
> + int i;
> +
> + for (i = 0; i < led->mc_cdev.num_leds; i++) {
> + if (led->color_component[i].color_id == color_id) {
I'd use plural "color_components" for the property name.
> + led->color_component[i].brightness = brightness;
> + return 0;
> + }
> + }
> +
> + return -EINVAL;
> +}
> +
> static int lp55xx_set_brightness(struct led_classdev *cdev,
> enum led_brightness brightness)
> {
> + struct led_mc_color_conversion color_component[LP55XX_MAX_GROUPED_CHAN];
> struct lp55xx_led *led = cdev_to_lp55xx_led(cdev);
> struct lp55xx_device_config *cfg = led->chip->cfg;
> + int ret;
> + int i;
>
> - led->brightness = (u8)brightness;
> - return cfg->brightness_fn(led);
> + if (led->mc_cdev.num_leds > 1) {
> + if (!cfg->multicolor_brightness_fn)
> + return -EINVAL;
> +
> + led_mc_calc_color_components(&led->mc_cdev, brightness,
> + color_component);
Similarly here - you calculate all components so it is weird to pass
variable of singular color_component form.
> +
> + for (i = 0; i < led->mc_cdev.num_leds; i++) {
> + ret = lp55xx_map_channel(led,
> + color_component[i].color_id,
> + color_component[i].brightness);
> + if (ret)
> + return ret;
> + }
> +
> + ret = cfg->multicolor_brightness_fn(led);
> + if (ret)
> + return ret;
> + } else {
> + led->brightness = (u8)brightness;
> + ret = cfg->brightness_fn(led);
> + }
> +
> + return ret;
[...]
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-10-16 20:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 15:59 [PATCH v13 00/18] Multicolor Framework v13 Dan Murphy
2019-10-16 15:59 ` [PATCH v13 01/18] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-10-16 15:59 ` [PATCH v13 02/18] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-10-16 15:59 ` [PATCH v13 03/18] " Dan Murphy
2019-10-16 15:59 ` [PATCH v13 04/18] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-10-19 18:33 ` Jacek Anaszewski
2019-10-16 15:59 ` [PATCH v13 05/18] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-10-16 15:59 ` [PATCH v13 06/18] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-10-16 15:59 ` [PATCH v13 07/18] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2019-10-16 15:59 ` [PATCH v13 08/18] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2019-10-16 15:59 ` [PATCH v13 09/18] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2019-10-17 16:10 ` Tony Lindgren
2019-10-16 15:59 ` [PATCH v13 10/18] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2019-10-28 2:55 ` Shawn Guo
2019-10-16 15:59 ` [PATCH v13 11/18] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2019-10-16 15:59 ` [PATCH v13 12/18] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2019-10-16 15:59 ` [PATCH v13 13/18] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2019-10-16 20:44 ` Jacek Anaszewski [this message]
2019-10-16 21:09 ` Jacek Anaszewski
2019-10-16 15:59 ` [PATCH v13 14/18] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2019-10-16 15:59 ` [PATCH v13 15/18] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2019-10-16 15:59 ` [PATCH v13 16/18] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2019-10-16 15:59 ` [PATCH v13 17/18] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2019-10-16 15:59 ` [PATCH v13 18/18] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d73452f-fd41-0b63-c79d-c29ed70867af@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).